include FindPython to skip bindings when no dev python is installed #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon; makes sure non-dev python versions are detected in config step
kevinkreiser
approved these changes
Feb 28, 2021
kevinkreiser
requested changes
Feb 28, 2021
kevinkreiser
approved these changes
Feb 28, 2021
|
osx build failure was just ephemeral, i wouldnt worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2883
CMake needs to be bumped to 3.12 to support FindPython. This checks for development headers as well and warns the user if there's no dev python installed.
Tasklist