Fix is_conditional_active(...) #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -365,7 +365,7 @@ bool is_conditional_active(const bool type, | |||
|
|
|||
| bool edge_case = false; // Jan 04 to Jan 01 | |||
| // month only | |||
| if (type == kYMD && (b_month && e_month) && (!b_day_dow && !e_day_dow && !b_week && !b_week) && | |||
| if (type == kYMD && (b_month && e_month) && (!b_day_dow && !e_day_dow && !b_week && !e_week) && | |||
There was a problem hiding this comment.
such an easy copy paste fail!
kevinkreiser
approved these changes
Jun 15, 2022
kevinkreiser
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3656
Found during static code analyzer running
The same condition is checked twice:
valhalla/src/baldr/datetime.cc
Line 368 in de5e4a7
It seems like in the second case
!e_weekshould be checked.What is the best way to cover this with test?
Tasklist