Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CostMatrix incorrect tile usage with oppedge #3719

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Fixed CostMatrix incorrect tile usage with oppedge #3719

merged 2 commits into from
Aug 21, 2022

Conversation

DmitryAk
Copy link
Contributor

@DmitryAk DmitryAk commented Aug 21, 2022 •
edited
Loading

Issue

Fix an issue in costmatrix.cc:
opp_edge is stored in t2 tile, but its cost is requested with another tile specified:

valhalla/src/thor/costmatrix.cc

Line 626 in 2f40cee

const DirectedEdge* opp_edge = t2->directededge(oppedge);

valhalla/src/thor/costmatrix.cc

Line 638 in 2f40cee

pred.cost() + costing_->EdgeCost(opp_edge, tile, TimeInfo::invalid(), flow_sources);

Tasklist

@DmitryAk DmitryAk marked this pull request as ready for review August 21, 2022 16:21
@kevinkreiser kevinkreiser merged commit 165ea84 into valhalla:master Aug 21, 2022
@DmitryAk DmitryAk deleted the da-fix-oppedge-tile branch August 21, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryAk @kevinkreiser