-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI C++17 #3878
CI C++17 #3878
Conversation
hm, of course some on linux, seems like the on macos, there's a few others in meili mostly apparently, mostly |
ah good, the libosmium issue was already fixed in osmcode/libosmium@e933414. and was release with 2.17.2. we're on 2.16.0. so I guess moving up the version should solve that. might as well go all the way to 2.18.0 (lots of deprecated stuff was removed there, but 2.17.x should work for us). |
Back on my office machine, it also failed with gcc 12.2.0 with the same std::iterator deprecations when building the tests. Strange it works on CI Linux machines. There's a nice post about the why: https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/. I (tentatively) fixed it quickly and I could build the test locally. Also upgraded to the latest libosmium release which went pretty smooth. |
start with #3877 , still wait for more feedback. more a quick test.