Parse lit tag #3893
Merged
Parse lit tag #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstnbwnkl
commented
Jan 6, 2023
| ["no"] = "false", | ||
| ["24/7"] = "true", | ||
| ["automatic"] = "true", | ||
| ["limited"] = "false", |
There was a problem hiding this comment.
lit=limited is a special case that, according to the OSM wiki mainly occurs in Austria and Germany, where it signifies that a street light marked with a "Laternenring" is not turned on during the whole night, so I guess we cannot reliably set the marked edge as lit=true
|
Yay thanks! Got my approval, but someone else should review and approve:) |
valhalla/mjolnir/osmway.h
Outdated
| @@ -1847,6 +1865,9 @@ struct OSMWay { | |||
|
|
|||
| // layer index(Z-level) of the way relatively to other levels | |||
| int8_t layer_; | |||
|
|
|||
| // whether or not the street is lit | |||
| bool lit_; | |||
There was a problem hiding this comment.
we should use a single bit of the spare2_ above
kevinkreiser
requested changes
Jan 10, 2023
kevinkreiser
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3848
This PR adds parsing of the
littag:graph.lualitas a member variable toOSMWaylitas a member variable to theDirectedEdgeclass, thereby allocating one of the remaining bitslittag and the values we parse totaginfo.jsonI also added a short parameterized test going through the different possible values of
lit, including its absence.