-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse lit tag #3893
Parse lit tag #3893
Conversation
["no"] = "false", | ||
["24/7"] = "true", | ||
["automatic"] = "true", | ||
["limited"] = "false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lit=limited
is a special case that, according to the OSM wiki mainly occurs in Austria and Germany, where it signifies that a street light marked with a "Laternenring" is not turned on during the whole night, so I guess we cannot reliably set the marked edge as lit=true
Yay thanks! Got my approval, but someone else should review and approve:) |
valhalla/mjolnir/osmway.h
Outdated
@@ -1847,6 +1865,9 @@ struct OSMWay { | |||
|
|||
// layer index(Z-level) of the way relatively to other levels | |||
int8_t layer_; | |||
|
|||
// whether or not the street is lit | |||
bool lit_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use a single bit of the spare2_
above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so other than the change to osmway.h this looks good, we'll ship it after we get that fixed up. thanks!
fixes #3848
This PR adds parsing of the
lit
tag:graph.lua
lit
as a member variable toOSMWay
lit
as a member variable to theDirectedEdge
class, thereby allocating one of the remaining bitslit
tag and the values we parse totaginfo.json
I also added a short parameterized test going through the different possible values of
lit
, including its absence.