-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bus=permit doesnt not override access=no #4045
Conversation
OK, I think that could explain it, since I believe the code change in #3413 was at some point working as intended with various busways around Brisbane. I noticed that the bridge (and the various other parts of the Brisbane busways) are tagged I tried searching the web for more information about Thanks for your help, and sorry if this is beyond the scope of what should be discussed here vs. elsewhere. |
no this discussion absolutely belongs here. https://wiki.openstreetmap.org/wiki/Tag:access%3Dpermit seems like for our purposes |
if we agree i can add it to the lua and tests |
jep totally agreed |
@kevinkreiser agree |
ok cool, since we agree ill add it to this pr! |
ah i see we already had |
… motorcycle where it was missing
something is wrong with github reporting build statuses here. the windows build succeeded. so did the changelog validation.. im just going to merge rather than try to rebuild |
Thank you for the quick fix! 🙏 |
fixes #4044
it was noticed that
access=no
wins overhighway=busway
. that does not seem to make sense so we probably have to fix up the lua. it is likely this tagging is meant to tell us no one is allow on it... except buses.EDIT:
as per usual i am thorougly confused after reading the osm wiki. it is clear that overriding access with
bus=yes
is what is normally used, but its not clear thathighway=busway
should function the same. the way our interpretation seems to work is we get default access from thehighway
tag then we turn it off or let it on depending on what theaccess
tag says, then finally we let that access for various modes get overriden by things likebus=yes
orbicycle=yes
etc.so im thinking perhaps this particular bridge is a tagging issue. adding
bus=yes
to it allows the test pass.EDIT:
lua was missing overrides for
bus=permit
andtaxi=permit
on ways. node access was also missing and for motorcycle as well