Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm unused import fixes building tests without prime_server #4705

Merged

Conversation

michaelkirk
Copy link
Contributor

Issue

The tests fail to build without prime_server, even with -DENABLE_SERVICES=OFF -DENABLE_HTTP=OFF.

I was going to do something fancier with cmake including different tests depending on the config, but it actually looks like this import was unused anyway.

Context

I'm trying to build valhalla for use as a library (really I'm only looking at using odin at the moment), so I don't need the service integration. Further, prime_server is failing to build for me, but that's for another issue.

Tasklist

I don't think any of these are relevant to this PR, but LMK:

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks. I wonder why circleci doesn't work for your PRs specifically, the other one too.. other external contributors don't have that problem I think (not many who are not part of the org somehow). anyways, OSX builds and runs the tests, that's good enough for this PR.

@michaelkirk
Copy link
Contributor Author

michaelkirk commented Apr 23, 2024

I wonder why circleci doesn't work for your PRs specifically,

I might be wrong, but I think I ran into something similar in another repository:
flatgeobuf/flatgeobuf#280

tldr: I don't have a circle CI account. Last time I checked, using circle CI seems to require me to give circle ci read/write access to every one of my repositories, which is a pretty tough sell for me.

@nilsnolde nilsnolde merged commit 9888d8e into valhalla:master Apr 24, 2024
3 of 5 checks passed
ADMUKHE pushed a commit to mercedes-benz/valhalla that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants