Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider migrating away from commons-httpclient #61

Closed
cvrebert opened this issue Mar 10, 2015 · 3 comments
Closed

Consider migrating away from commons-httpclient #61

cvrebert opened this issue Mar 10, 2015 · 3 comments

Comments

@cvrebert
Copy link
Contributor

The project has been end-of-life-ed. Its successor is the Apache HttpComponents project's HttpClient, although I have no idea whether or not that's the most preferable library in today's Java ecosystem.

@sideshowbarker
Copy link
Contributor

So yeah we need to migrate to something new anyway—to get SNI support, because commons-httpclient doesn’t set SNI.

Its successor is the Apache HttpComponents project's HttpClient, although I have no idea whether or not that's the most preferable library in today's Java ecosystem

Given that we have to migrate to something new regardless, and change or code to write to some new API regardless, it might make sense to try some non-Apache-project thing, if there’s something that stands out as being better. But a quick look around doesn’t seem to indicate that there is any, so I reckon we should just go ahead and migrate to HttpComponents. But I’ll do a little more investigation before doing that. And anyway we definitely want @hsivonen to weigh in on this.

@sideshowbarker
Copy link
Contributor

I found a couple of commons-httpclient⇒HttpComponents HttpClient migration guides:

http://blog.teamextension.com/migrating-from-httpclient-3-1-to-4-0-34
http://debuguide.blogspot.jp/2013/01/quick-guide-for-migration-of-commons.html

It looks like it would take at least a couple hours to migrate the validator sources and test them, so I’d be glad if somebody wanted to contribute a patch for this. Otherwise it’s not likely I’ll get around to until this weekend at the earliest.

@sideshowbarker
Copy link
Contributor

I pushed out a nightly with the change included—https://sideshowbarker.net/nightlies/vnu.jar

tripu pushed a commit to tripu/validator that referenced this issue Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants