-
Notifications
You must be signed in to change notification settings - Fork 271
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider migrating away from commons-httpclient #61
Comments
So yeah we need to migrate to something new anyway—to get SNI support, because commons-httpclient doesn’t set SNI.
Given that we have to migrate to something new regardless, and change or code to write to some new API regardless, it might make sense to try some non-Apache-project thing, if there’s something that stands out as being better. But a quick look around doesn’t seem to indicate that there is any, so I reckon we should just go ahead and migrate to HttpComponents. But I’ll do a little more investigation before doing that. And anyway we definitely want @hsivonen to weigh in on this. |
I found a couple of commons-httpclient⇒HttpComponents HttpClient migration guides: http://blog.teamextension.com/migrating-from-httpclient-3-1-to-4-0-34 It looks like it would take at least a couple hours to migrate the validator sources and test them, so I’d be glad if somebody wanted to contribute a patch for this. Otherwise it’s not likely I’ll get around to until this weekend at the earliest. |
I pushed out a nightly with the change included—https://sideshowbarker.net/nightlies/vnu.jar |
Fixes validator#33. Thanks @tkrotoff. Fixes validator#61. Thanks @cvrebert.
The project has been end-of-life-ed. Its successor is the Apache HttpComponents project's
HttpClient
, although I have no idea whether or not that's the most preferable library in today's Java ecosystem.The text was updated successfully, but these errors were encountered: