Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add Sierra Leone phone and fix Sri Lanka phone #1558

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fix: add Sierra Leone phone and fix Sri Lanka phone #1558

merged 1 commit into from
Apr 18, 2021

Conversation

ezkemboi
Copy link
Member

@ezkemboi ezkemboi commented Dec 20, 2020 •
edited
Loading

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Dec 20, 2020 •
edited
Loading

Codecov Report

Merging #1558 (36ab809) into master (3f70b8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1847      1847           
=========================================
  Hits          1847      1847
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f70b8e...36ab809. Read the comment docs.

profnandaa
profnandaa previously approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@profnandaa
Copy link
Member

@ezkemboi -- fix the m/c.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 18, 2021
@ezkemboi
Copy link
Member Author

@profnandaa fixed the m/c

@profnandaa profnandaa merged commit cf403d0 into validatorjs:master Apr 18, 2021
@ezkemboi ezkemboi mentioned this pull request Jan 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezkemboi @profnandaa