Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(isMobilePhone.js): Updating regex of Belgium and the valid and invalid phone numbers in validators.js #1746

Conversation

divikshrivastava
Copy link
Contributor

@divikshrivastava divikshrivastava commented Oct 2, 2021

This PR contains the updation of regex for Belgian's mobile number validation (nl-BE), along with correction of valid and invalid numbers in validators.js

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @divikshrivastava and congrats for your first PR here 👏
Your tests are not passing, can you please fix that?

@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 2, 2021
@divikshrivastava
Copy link
Contributor Author

Thank you @divikshrivastava and congrats for your first PR here 👏 Your tests are not passing, can you please fix that?

…js since phone number rules will be same for that too
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #1746 (843671d) into master (c899b31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1746   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2015      2015           
  Branches       454       454           
=========================================
  Hits          2015      2015           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...843671d. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Is your participation as part of hacktoberfest ?

@divikshrivastava
Copy link
Contributor Author

Yes sir! @tux-tn

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 2, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🎉

@profnandaa profnandaa merged commit 4ec30b7 into validatorjs:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants