Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added german messages #21

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Added german messages #21

merged 2 commits into from
Jun 26, 2019

Conversation

mpe85
Copy link
Contributor

@mpe85 mpe85 commented Jun 21, 2019

I added messages for the locale de_DE (German - Germany)

@rodolphocouto
Copy link
Member

Hi @mpe85,

Thanks for your contribution!

Can you also add messages for valiktor-javamoney and valiktor-jodamoney modules?

@mpe85
Copy link
Contributor Author

mpe85 commented Jun 25, 2019

I just updated my PR.
If you add more validation rules in the future, feel free to ask me for german messages :-)

@rodolphocouto rodolphocouto added this to the 0.7.0 milestone Jun 26, 2019
@rodolphocouto
Copy link
Member

I just updated my PR.
If you add more validation rules in the future, feel free to ask me for german messages :-)

Thank you, I'll certainly ask you :)

@rodolphocouto rodolphocouto merged commit 1ce4dd7 into valiktor:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpe85 @rodolphocouto