Implemented a generic approach for the addition of new validation types. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 4, 2020 21:11
… that has an implementation of the new parent class "ReceiverValidator".
…d avoid code duplications.
|
Would love to hear your opinion @rodolphocouto before I invest more time to make the code more generic and implement tests. :) Edit: I now adapted one test in order to showcase the usage of the new functionality. |
|
Moved on from valiktor and solved my problem another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Proposed Changes
Draft
This Pull Request is a draft because I have not adapted the tests, yet. Please let me know if you like my approach and would consider merging it into the upstream. If so, I will adapt the tests so that each relevant test tests both
KPropertyandKFunction.Also, I don't have any strong opinions on the naming, so feel free to suggest a better name than "ReceiverValidator" for the base class.