Add documentation for script-show #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
reviewed
Jun 17, 2024
hwware
reviewed
Jun 18, 2024
madolson
added a commit
to valkey-io/valkey
that referenced
this pull request
Jun 19, 2024
In some scenarios, the business may not be able to find the previously used Lua script and only have a SHA signature. Or there are multiple identical evalsha's args in monitor/slowlog, and admin is not able to distinguish the script body. Add a new script subcommmand to show the contents of script given the scripts sha1. Returns a NOSCRIPT error if the script is not present in the cache. Usage: `SCRIPT SHOW sha1` Complexity: `O(1)` Closes #604. Doc PR: valkey-io/valkey-doc#143 --------- Signed-off-by: wei.kukey <wei.kukey@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
|
@kukey Can you update this PR to SCRIPT SHOW? |
OK |
Change-Id: I9213aa113bcbf1337ac25e8f0540155e25eb1d05 Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Change-Id: Id6bfa9dd83006a6217134eb1ac1d1acd7ece7f96 Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Wen Hui <wen.hui.ware@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Wen Hui <wen.hui.ware@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Change-Id: Id894398da2d6ab907196a0db754e6202ee1481ff Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Signed-off-by: kukey <wei.kukey@gmail.com>
zuiderkwast
reviewed
Jul 13, 2024
Change-Id: I983b3c823e0cc87af0779458f832db9147ff0a7e Signed-off-by: wei.kukey <wei.kukey@gmail.com>
madolson
reviewed
Jul 14, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
approved these changes
Jul 14, 2024
|
The title is still wrong and the committed message... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for valkey-io/valkey#617
Change-Id: I9213aa113bcbf1337ac25e8f0540155e25eb1d05