-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for script-show #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the file to script-show
.
In some scenarios, the business may not be able to find the previously used Lua script and only have a SHA signature. Or there are multiple identical evalsha's args in monitor/slowlog, and admin is not able to distinguish the script body. Add a new script subcommmand to show the contents of script given the scripts sha1. Returns a NOSCRIPT error if the script is not present in the cache. Usage: `SCRIPT SHOW sha1` Complexity: `O(1)` Closes #604. Doc PR: valkey-io/valkey-doc#143 --------- Signed-off-by: wei.kukey <wei.kukey@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@kukey Can you update this PR to SCRIPT SHOW? |
OK |
Change-Id: I9213aa113bcbf1337ac25e8f0540155e25eb1d05 Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Change-Id: Id6bfa9dd83006a6217134eb1ac1d1acd7ece7f96 Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Wen Hui <wen.hui.ware@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Co-authored-by: Wen Hui <wen.hui.ware@gmail.com> Signed-off-by: kukey <wei.kukey@gmail.com> Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Change-Id: Id894398da2d6ab907196a0db754e6202ee1481ff Signed-off-by: wei.kukey <wei.kukey@gmail.com>
Signed-off-by: kukey <wei.kukey@gmail.com>
Change-Id: I983b3c823e0cc87af0779458f832db9147ff0a7e Signed-off-by: wei.kukey <wei.kukey@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor wording improvements I'll apply.
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
The title is still wrong and the committed message... |
Docs for valkey-io/valkey#617
Change-Id: I9213aa113bcbf1337ac25e8f0540155e25eb1d05