-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate man pages #92
Conversation
A Makefile provides 'make' and 'make install' which generates and installs for man pages. Man pages are built for the binaries (valkey-cli, etc. prefixed by "valkey-", section 1), Config (valkey.conf, section 4), Valkey commands (section 3valkey), documentation overview page ("valkey", section 7) and tutorials and everything else (prefixed by "valkey-", section 7). Scripts in Python are used for preprocessing and pandoc is used to convert markdown to man pages, stored under utils/. A target 'make html' is also provided, to build HTML pages to use locally. This is also using pandoc. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This commit adds usage details to the pages for these programs, making them a bit closer to the structure of standard man pages for programs. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Seen some nits.
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@Conan-Kudo @guillemj FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. I didn't look too deeply through all the code but I read all the changes on the text files.
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Delete parts of RSAL which weren't deleted in 8f8e4bf. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this awesome!
A Makefile provides 'make' and 'make install' to generate and install man pages.
Man pages are built for the binaries (valkey-cli, etc. prefixed by "valkey-",
section 1), Config (valkey.conf, section 4), Valkey commands (section 3valkey),
documentation overview page ("valkey", section 7) and tutorials and everything
else (prefixed by "valkey-", section 7).
Scripts in Python are used for preprocessing and pandoc is used to convert
markdown to man pages, stored under utils/.
A target 'make html' is also provided, to build HTML pages to use locally.
This is also using pandoc.
The documentation pages for
valkey-cli
,valkey-benchmark
andvalkey-sentinel
are expanded with usage and options to match what's expected from a man page for a program. A page forvalkey-server
is added. (We didn't have one.)README.md is update with info on how to build and install man pages. Other info regarding the doc repo is slightly updated.
Fixes #69.
Reviewers: I suggest checking out my branch and trying
make -j10 VALKEY_ROOT=path/to/valkey
andsudo make install
. Thenman valkey
to start with.