Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate man pages #92

Merged
merged 12 commits into from
May 24, 2024
Merged

Generate man pages #92

merged 12 commits into from
May 24, 2024

Conversation

zuiderkwast
Copy link
Contributor

A Makefile provides 'make' and 'make install' to generate and install man pages.

Man pages are built for the binaries (valkey-cli, etc. prefixed by "valkey-",
section 1), Config (valkey.conf, section 4), Valkey commands (section 3valkey),
documentation overview page ("valkey", section 7) and tutorials and everything
else (prefixed by "valkey-", section 7).

Scripts in Python are used for preprocessing and pandoc is used to convert
markdown to man pages, stored under utils/.

A target 'make html' is also provided, to build HTML pages to use locally.
This is also using pandoc.

The documentation pages for valkey-cli, valkey-benchmark and valkey-sentinel are expanded with usage and options to match what's expected from a man page for a program. A page for valkey-server is added. (We didn't have one.)

README.md is update with info on how to build and install man pages. Other info regarding the doc repo is slightly updated.

Fixes #69.

Reviewers: I suggest checking out my branch and trying make -j10 VALKEY_ROOT=path/to/valkey and sudo make install. Then man valkey to start with.

A Makefile provides 'make' and 'make install' which generates and
installs for man pages.

Man pages are built for the binaries (valkey-cli, etc. prefixed by "valkey-",
section 1), Config (valkey.conf, section 4), Valkey commands (section 3valkey),
documentation overview page ("valkey", section 7) and tutorials and everything
else (prefixed by "valkey-", section 7).

Scripts in Python are used for preprocessing and pandoc is used to convert
markdown to man pages, stored under utils/.

A target 'make html' is also provided, to build HTML pages to use locally.
This is also using pandoc.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This commit adds usage details to the pages for these programs, making them
a bit closer to the structure of standard man pages for programs.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast changed the title Man pages Generate man pages May 22, 2024
@zuiderkwast zuiderkwast requested a review from madolson May 22, 2024 21:12
@zuiderkwast
Copy link
Contributor Author

image image
image image

Copy link
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seen some nits.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
topics/benchmark.md Outdated Show resolved Hide resolved
utils/build-command-groups.py Show resolved Hide resolved
zuiderkwast and others added 4 commits May 23, 2024 10:46
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>

Co-authored-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast
Copy link
Contributor Author

@Conan-Kudo @guillemj FYI

Makefile Show resolved Hide resolved
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. I didn't look too deeply through all the code but I read all the changes on the text files.

topics/server.md Outdated Show resolved Hide resolved
topics/server.md Outdated Show resolved Hide resolved
topics/server.md Outdated Show resolved Hide resolved
utils/build-command-index.py Outdated Show resolved Hide resolved
utils/check-links.pl Outdated Show resolved Hide resolved
topics/server.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
zuiderkwast and others added 2 commits May 23, 2024 20:14
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>

Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Delete parts of RSAL which weren't deleted in 8f8e4bf.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this awesome!

@zuiderkwast zuiderkwast merged commit 5f279b9 into valkey-io:main May 24, 2024
1 check passed
@zuiderkwast zuiderkwast deleted the man-pages branch May 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Man pages
4 participants