-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Replace instances of Redis with Valkey #2266
Python: Replace instances of Redis with Valkey #2266
Conversation
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
…alkey Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
@@ -10,7 +10,7 @@ | |||
SCRIPT_FILE = os.path.abspath(f"{__file__}/../../../../../utils/cluster_manager.py") | |||
|
|||
|
|||
class RedisCluster: | |||
class ValkeyCluster: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before python release, it was decided to leave this as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? I don't really see how changing this to ValkeyCluster is problematic. This is a Valkey client.
…alkey Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
…alkey Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
…alkey Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
No description provided.