Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade centos7 to centos stream9 #532

Closed
wants to merge 1 commit into from

Conversation

adetunjii
Copy link
Contributor

  • Add support for Almalinux

Closes #527

Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
@madolson madolson self-requested a review May 22, 2024 15:50
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you formatted the YAML files. If we go down that path, I would like to add some automated format checker as part of the build so they don't become "unformatted" again. My preference would be we split this into two PRs, do the CentOS updates first (to unblock your other PR) and then add the formatter (you're more than welcome to pick that up if you want).

@adetunjii
Copy link
Contributor Author

I see you formatted the YAML files. If we go down that path, I would like to add some automated format checker as part of the build so they don't become "unformatted" again. My preference would be we split this into two PRs, do the CentOS updates first (to unblock your other PR) and then add the formatter (you're more than welcome to pick that up if you want).

@madolson Yh sure. Not a problem. Please just create an issue for it. I'll pick it up

@madolson
Copy link
Member

@adetunjii #533

@zuiderkwast
Copy link
Contributor

zuiderkwast commented May 25, 2024

Replaced by #543. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CentOS 7 image with CentOS Stream 9
3 participants