replace centos 7 with almalinux 8, add almalinux 9, centos stream 9, … #543
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #543 +/- ##
============================================
- Coverage 70.17% 70.13% -0.04%
============================================
Files 109 109
Lines 59904 59905 +1
============================================
- Hits 42039 42016 -23
- Misses 17865 17889 +24 |
…fedora stable/rawhide Signed-off-by: Jonathan Wright <jonathan@almalinux.org>
There was a problem hiding this comment.
Also kicked off another run just to double check they aren't flaky or anything. https://github.com/valkey-io/valkey/actions/runs/9226495711/job/25386381848
| @@ -731,20 +774,20 @@ jobs: | |||
| echo "skiptests: ${{github.event.inputs.skiptests}}" | |||
| echo "test_args: ${{github.event.inputs.test_args}}" | |||
| echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" | |||
| # On centos7 actions/checkout@v4 does not work, so we use v3 | |||
| # ref. https://github.com/actions/checkout/issues/1487 | |||
There was a problem hiding this comment.
Indeed :)
What about moving to more general tagging on the checkout action instead of using a straight commit hash?
There was a problem hiding this comment.
I haven't read the issue, but apparently it was included in the openSSF score card.
|
Forked repositories have recurring workflows disabled by default so that shouldn't be needed.
|
You aren't wrong. I'm not exactly sure of the history of that feature, but we didn't want to change it now because it might have wider implications for folks that pull on their forks. Maybe now is the time to change it. |
|
@jonathanspw Can you fix the DCO check (sign-off on the last three commits). Otherwise I can do it since you were taking my changes. |
I used the GH GUI to pull those in. No clue how to do DCO with the GUI. Can you do it? |
|
@jonathanspw I'm sorry, I pushed the wrong branch to your unstable branch and github did not appreciate that (and closed the PR, so I can't update it anymore). Would you mind pushing the content https://github.com/valkey-io/valkey/tree/unstable_jon onto your unstable branch? That should pass all of the checks and will allow my to re-open and merge the PR. |
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Jonathan Wright <jonathan@almalinux.org>
|
I did a forced push to my branch that included that. Will it let you reopen it now? |
|
Hmm I didn't notice there's a piece in normal CI that does a build on CentOS 7. If you'll give me a minute I can add a commit that will change that as well, unless you'd rather it come in a separate PR. |
Up to you, I don't have a strong preference. Although I guess it makes sense to do in this PR. |
Signed-off-by: Jonathan Wright <jonathan@almalinux.org>
|
This is ready to merge. Example of a run with the new code in place: https://github.com/jonathanspw/valkey/actions/runs/9228120347/job/25391510821 |
replace centos 7 with almalinux 8, add almalinux 9, centos stream 9, fedora stable, rawhide Fixes valkey-io#527 --------- Signed-off-by: Jonathan Wright <jonathan@almalinux.org> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
replace centos 7 with almalinux 8, add almalinux 9, centos stream 9, fedora stable, rawhide Fixes valkey-io#527 --------- Signed-off-by: Jonathan Wright <jonathan@almalinux.org> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
replace centos 7 with almalinux 8, add almalinux 9, centos stream 9, fedora stable, rawhide Fixes #527 --------- Signed-off-by: Jonathan Wright <jonathan@almalinux.org> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
…fedora stable/rawhide
Fixes #527