Make Override a first-class citizen, not just a dict #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
first-class-override
branch
from
3cda9f2
to
f026a78
Compare
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 92.15% 92.32% +0.17%
==========================================
Files 60 61 +1
Lines 1771 1798 +27
Branches 298 299 +1
==========================================
+ Hits 1632 1660 +28
Misses 72 72
+ Partials 67 66 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akx
force-pushed
the
first-class-override
branch
2 times, most recently
from
0a11fa5
to
53d31f0
Compare
ruksi
approved these changes
Aug 3, 2023
|
|
||
| @classmethod | ||
| def parse(cls, data: SerializedDict) -> Override: | ||
| kwargs = parse_common_step_properties(data) |
There was a problem hiding this comment.
reuse from the step.parse, good good yes yes
Co-authored-by: Aarni Koskela <akx@iki.fi>
akx
force-pushed
the
first-class-override
branch
from
53d31f0
to
391dcd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #97.