Preserve workload resources structure on serialization #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Can you base the test on the (apparently unused!) step_with_resources fixture (i.e. step-with-resources.yaml) that was added in #121? When using our examples fixtures, we automagically do both direct and round-tripped variants of the test. As I see it, that should surface the bug.
Workload resource keys ("cpu", "memory", etc.) need to be preserved so
that the UI can correctly parse the resource values.
teroyks
force-pushed
the
tero/fix/resources-serialization
branch
from
724207c
to
be3cbc4
Compare
teroyks
commented
Nov 1, 2023
Comment on lines
+6
to
+7
| assert isinstance(resources, dict), "Resources should be defined." | ||
| assert "cpu" in resources, "Resources should contain data." |
There was a problem hiding this comment.
These lines serve more to demonstrate the serialized result than to actually test the process – without the fix, the serialization crashes before reaching here.
Right. Done, pushed a rebased commit (without the unneeded new test data). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/valohai/meta/issues/275
Workload resource keys (
cpu,memory, etc.) need to be preserved so that the UI can correctly parse the resource values.Serialized resources in step before:
{'resources': [{'max': 20, 'min': 10}, {'max': 1.0, 'min': 0.5}, {'big machine': 2}]}After:
{'resources': {'cpu': {'max': 20, 'min': 10}, 'devices': {'big machine': 2}, 'memory': {'max': 1.0, 'min': 0.5}}}The default for most keys (all of them so far) is to flatten them, which is why the test is a bit backwards (
not in [do_not_flatten]instead ofkey in [do_flatten]).