-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary import of FORM_DIRECTIVES in charts.js causes value accessor error with RC 5 and material 2 Alpha 7 #352
Comments
Same problem here - and from looking at the source, it doesn't appear that Can this be removed? |
@petewalker Yes agree, I removed it and i don't see any side effect. |
I remove it too. And everything works fine so far. |
I'm seeing this issue as well and the workaround mentioned by @naveedahmed1 works for now, but a more permanent fix would be really nice. For development it's not that big of a deal, but even for that it means that others working on the same project that happen to run npm install to pull in dependencies have to deal with the workaround as well. For us the error results in forms being controlled by the FormsModule causing a Template parse error that looks like the following:
|
I see that PR #343 incorporates a fix for this and is in the development branch. Do you have an ETA on when that might make it into the npm package? Thanks! |
Closing for inactivity - if issue persists, feel free to comment with a working example which demonstrates the issue. |
Hi,
It seems that there is an unnecessary import of FORM_DIRECTIVES in charts.js which causes value accessor error with Angular 2 RC 5 and material 2 Alpha 7.
I removed that from the directives list in charts.js and the error was gone.
Can you please review and check if
common_1.FORM_DIRECTIVES,
is actually necessary to add in directives?
The text was updated successfully, but these errors were encountered: