Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary import of FORM_DIRECTIVES in charts.js causes value accessor error with RC 5 and material 2 Alpha 7 #352

Closed
naveedahmed1 opened this issue Aug 13, 2016 · 6 comments

Comments

@naveedahmed1
Copy link

Hi,

It seems that there is an unnecessary import of FORM_DIRECTIVES in charts.js which causes value accessor error with Angular 2 RC 5 and material 2 Alpha 7.

I removed that from the directives list in charts.js and the error was gone.

Can you please review and check if

common_1.FORM_DIRECTIVES,

is actually necessary to add in directives?

@petewalker
Copy link

Same problem here - and from looking at the source, it doesn't appear that FORM_DIRECTIVES are even being used?

Can this be removed?

@naveedahmed1
Copy link
Author

@petewalker Yes agree, I removed it and i don't see any side effect.

@raychenfj
Copy link

I remove it too. And everything works fine so far.

@jbgarr
Copy link

jbgarr commented Aug 23, 2016

I'm seeing this issue as well and the workaround mentioned by @naveedahmed1 works for now, but a more permanent fix would be really nice. For development it's not that big of a deal, but even for that it means that others working on the same project that happen to run npm install to pull in dependencies have to deal with the workaround as well.

For us the error results in forms being controlled by the FormsModule causing a Template parse error that looks like the following:

zone.js:478 Unhandled Promise rejection: Template parse errors: Reference <#FormNameHere> is defined several times

@cbomkamp
Copy link

I see that PR #343 incorporates a fix for this and is in the development branch. Do you have an ETA on when that might make it into the npm package? Thanks!

@paviad
Copy link
Contributor

paviad commented Mar 4, 2019

Closing for inactivity - if issue persists, feel free to comment with a working example which demonstrates the issue.

@paviad paviad closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants