Fix chartClick emit

[Eugeno]

Broken since 3.0.6

[Eugeno]

Hm, fallen test. Ok, you have a test only for click, not for hover.
Since 3.0.6 onHover has this.chartHover.observed condition, but onClick has !this.chartHover.observed. Looks like something wrong here =)

[boytsovevg]

any updates?

[santam85]

Should be fixed in 838882c, I will release soon

[moduld]

Tried with version 3.0.9 - doesn't work.

[santam85]

Can you provide a reproduction stackblitz for me?

[santam85]

I think I know what's going on: the event will trigger only if you hover an actual element (active needs not to be null or empty) for performance reasons. Have you tried actually hovering an element in the dataset? The event triggers correctly for me, I will add a test that demonstrates that. This PR is preventing all events to trigger when an observer is present, will close and reject.

[moduld]

I use 'bubble' type of chart. I try to handle (chartClick) event when I click on a bubble. So the bubble is hovered at moment of click. I tried to use v3.0.5 - and the event emits properly (but the version affects changeDetection for a component where the chart is used)

[santam85]

Can you try with v3.0.10?

[moduld]

Tried with v3.0.10 - the same issue.

[santam85]

Please create a repo with a reproduction example, I really can't see how this is not working for you. Is it about clicking or hovering? I am confused...

[moduld]

ok, I created a sample here https://codesandbox.io/s/billowing-pond-vq9rhn

[moduld]

Hello @santam85 . Any updates regarding the issue?

[santam85]

The culpirit seems to be the outdated version odf rxjs, I tested with 7.4.0 and works fine in your example. Will double check again which minor of 6.x is needed and update peer dependencies accordingly.

[moduld]

yes, you're right. I updated the rxjs version in my project to the latest and the issue has gone. Thanks!

[santam85]

v3.0.11 should now also be compatible with rxjs 6.x