Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drake On Remove Parameter Mismatch #842

Closed
OliverUlm opened this issue Mar 15, 2018 · 1 comment
Closed

drake On Remove Parameter Mismatch #842

OliverUlm opened this issue Mar 15, 2018 · 1 comment
Labels
Milestone

Comments

@OliverUlm
Copy link

OliverUlm commented Mar 15, 2018

I have a rather complex layout with several bags. In some circumstances the backing arrays would not update correctly due to the indizes between the models and containers arrays on the drake not lining up correctly.

I found out that while the DragulaService handles the remove event from dragula it only expects 2 parameters ( el and source). Dragula however provides 3 (el, parent and source). Quite often parent is identical to source so it's no issue but sometimes (and I've not yet found out why) it's not identical and ng2-dragula tries to remove the object from the parent instead of the actual source.

The issue is easily remedied by adding the missing parameter in the DragulaService like this:

drake.on('remove', function (el, parent, source) {

PS: Affected version: 1.5.0

@cormacrelf
Copy link
Contributor

PR is #855

@cormacrelf cormacrelf added this to the 2.0.0 milestone Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants