-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(modal): change to add Dismiss Reason on modal hide with back click (
#5942) * fix(modal): change to add Dismiss Reason on modal hide with back navigation change to show Dismiss Reason on modal hide * Removed unwanted changes * fix(modal): fix lint issue Co-authored-by: Ankit Mishra <ankitmishra@Ankit-MacBook-Pro.local> Co-authored-by: Dmitry Danilov <daniloff200@gmail.com>
- Loading branch information
1 parent
9583752
commit bf25a11
Showing
3 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it should be call before this.hide();
@cankitm Can you change the order?
In other cases (
onEsc
,onClickStop
), callsetDismissReason
beforehide
.It can be a problem in the future.