Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker) add croatian locale #5387

Merged
merged 5 commits into from
Sep 13, 2019

Conversation

cobaltsis
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #5387 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5387   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988f5cf...fe2e982. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

This locale is not available in the DEMO, so need to add appropriate changes to /demo-datepicker.module.ts

@Domainv Domainv changed the title Croatian locale feat(datepicker) add croatian locale Sep 12, 2019
@Domainv
Copy link
Contributor

Domainv commented Sep 12, 2019

added to demo

@ludmilanesvitiy
Copy link
Contributor

TLG

@Domainv Domainv merged commit d5a51e4 into valor-software:development Sep 13, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* Added locales for croatian language

* Fixed tests

* feat(doc): add croatian locale to demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants