Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): fix stackblitz build, fix core-js not correct version #5956

Merged
merged 1 commit into from
Oct 13, 2020
Merged

fix(demo): fix stackblitz build, fix core-js not correct version #5956

merged 1 commit into from
Oct 13, 2020

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Oct 12, 2020 •
edited
Loading

PR Checklist

fixes #5955

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

valorkin
valorkin approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@valorkin valorkin merged commit 61c6924 into development Oct 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-cors-js-version-fix-stackblitz-demo branch October 13, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees
No one assigned
Labels
comp(demo) hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with core-js package during stackblitz example builds
2 participants
@daniloff200 @valorkin