Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapse): fix setting display value #6257

Merged
merged 3 commits into from Sep 7, 2021

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented Aug 5, 2021

fix(collapse): fix setting display value
refs #6070 refs #6071

@valorkin valorkin temporarily deployed to ngx-bootstra-fix-collap-icwy62 August 5, 2021 13:19 Inactive
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

Visit the preview URL for this PR (updated for commit c702e0e):

https://ngx-bootstrap-demo--pr6257-fix-collapse-display-k2ocsxxd.web.app

(expires Mon, 13 Sep 2021 14:34:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #6257 (64bb7d8) into development (6c138db) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 64bb7d8 differs from pull request most recent head c702e0e. Consider uploading reports for the commit c702e0e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6257      +/-   ##
===============================================
+ Coverage        77.24%   77.27%   +0.02%     
===============================================
  Files              311      311              
  Lines            10681    10678       -3     
  Branches          2625     2625              
===============================================
  Hits              8251     8251              
+ Misses            2420     2417       -3     
  Partials            10       10              
Impacted Files Coverage Δ
src/collapse/collapse.directive.ts 73.86% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c138db...c702e0e. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 5, 2021



Test summary

87 0 6 0


Run details

Project ngx-bootstrap
Status Passed
Commit 64bb7d8 ℹ️
Started Sep 6, 2021 2:35 PM
Ended Sep 6, 2021 2:40 PM
Duration 05:07 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@valorkin valorkin temporarily deployed to ngx-bootstra-fix-collap-icwy62 August 5, 2021 13:56 Inactive
@valorkin valorkin added this to the 2021-09-10 milestone Sep 7, 2021
@valorkin valorkin merged commit aaf1240 into development Sep 7, 2021
@valorkin valorkin deleted the fix-collapse-display-value branch September 7, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants