fix(collapse): respect display input value

[marcinmajkowski]

This change removes race conditions caused by TypeScript setters being called by Angular in non-deterministic order. Setters side effects (reading values set in other setters) are moved to ngOnChanges lifecycle hook. The consequence is that those side effects are no longer called when those inputs are set other than in the template. This is a breaking change but methods to call instead of setting those properties are already provided (show/hide) so migration path is straightforward. Setting display to 'none' no longer hides the collapse, setting collapse input to true or calling hide method is the way to go.

BREAKING CHANGE: setting display or collapse property on CollapseDirective no longer expands/collapses the collapse - use show/hide methods instead or set collapse input in template

No changes in tests since those are currently structured such that I cannot add display property for only one case (there is single shared template). I can restructure the tests to use separate templates (with overrideComponent) if you wish (I consider this major change since most likely majority of lines in spec file will be affected) .

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

• read and followed the CONTRIBUTING.md guide.
• built and tested the changes locally.
• added/updated tests.
• added/updated API documentation.
• added/updated demos.

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.83%. Comparing base (2c671b6) to head (6a4ada2).
⚠️ Report is 247 commits behind head on development.

Files with missing lines	Patch %	Lines
src/collapse/collapse.directive.ts	71.42%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #6071      +/-   ##
===============================================
+ Coverage        69.78%   69.83%   +0.04%     
===============================================
  Files              343      343              
  Lines             9235     9227       -8     
  Branches          2007     2006       -1     
===============================================
- Hits              6445     6444       -1     
+ Misses            2195     2189       -6     
+ Partials           595      594       -1     

Files with missing lines	Coverage Δ
src/collapse/collapse.directive.ts	70.66% <71.42%> (+5.60%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c671b6...6a4ada2. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cypress]

---

Test summary

82 • 5 • 6 • 0

---

Run details

Project	ngx-bootstrap
Status	Failed
Commit	b2a2401 ℹ️
Started	Apr 29, 2021 9:50 AM
Ended	Apr 29, 2021 9:54 AM
Duration	04:27 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 87

View run in Cypress Dashboard ➡️

---

Failures

	carousel_page_spec.ts		1
1	Carousel page testing suite > Basic > when user click on left/right arrow - previous/next slide shown
	datepicker_page_spec.ts		4
1	Datepicker demo page testing suite > Basic daterangepicker > when user clicks on "Daterangepicker" input after datepicker, 2d container opened and 1t closed range contains 2 calendar blocks, 2 arrows: "‹/›", shown interval from current month/year and next
2	Datepicker demo page testing suite > Basic daterangepicker > when user clicks on "‹" - shown interval, which started from previous month
3	Datepicker demo page testing suite > Basic daterangepicker > when user clicks on "›" - shown interval, which started from next month
4	Datepicker demo page testing suite > Basic daterangepicker > when user clicks on month, 2 tables with 12 months in each shown with years(current, next) in head

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard