feat(affix) #339
feat(affix) #339
Conversation
|
This is Fckn huge! Looks really good, some things could be simplified a bit, let me get to PC. One note, now you could have difficulties with squashing to one commit because of merge commit at the end, so try to use git pull rebase when possible, it will make life easier for you :) |
|
Did you find time to investigate it? Any feedback? I tried staying pretty close to the bootstrap javascript implementation, as I think they figured out the best approach to get it working in as many configurations as possible. |
|
What's the status of this PR? :) Would be great feature |
|
+1, would be an awesome improvement! |
|
Waiting for this. +1 |
|
+1 Would love to see this added. |
|
Any update on this? Would be nice to have! |
| } | ||
|
|
||
| private checkPosition():void { | ||
| let elemPos = positionService.position(this.el.nativeElement); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| let scrollTop:number = this.body.scrollTop; // current scroll position in pixels from top | ||
| let targetHeight:number = this.window.innerHeight; // Height of the window / viewport area | ||
|
|
||
| if (offsetTop !== null && this.status === AffixStatus.AFFIX_TOP) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Any update on this? Do we planning to add affix to ngx-bootstrap anytime soon? |
|
this already implemented or still not? |
The bootstrap affix component as angular2 directive in typescript. Appreciating your feedback!