feat(timepicker): Add ability to set readonly/disabled state #3602 #3611

IraErshova · 2018-02-01T09:23:44Z

Add ability to set readonly/disabled state
Add disable state demo
Fix bug related to highlight input in readonly state

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.
added/updated API documentation.
added/updated demos.

codecov · 2018-02-01T09:52:54Z

Codecov Report

Merging #3611 into development will increase coverage by 0.16%.
The diff coverage is 89.47%.

@@               Coverage Diff               @@
##           development    #3611      +/-   ##
===============================================
+ Coverage        72.05%   72.21%   +0.16%     
===============================================
  Files              252      252              
  Lines             8159     8225      +66     
  Branches          1552     1566      +14     
===============================================
+ Hits              5879     5940      +61     
- Misses            1858     1863       +5     
  Partials           422      422

Impacted Files	Coverage Δ
src/timepicker/timepicker.utils.ts	`97.97% <100%> (+1.68%)`	⬆️
src/timepicker/timepicker.config.ts	`100% <100%> (ø)`	⬆️
src/timepicker/timepicker-controls.util.ts	`100% <100%> (+4.05%)`	⬆️
src/timepicker/reducer/timepicker.reducer.ts	`76.74% <12.5%> (-12.45%)`	⬇️
src/timepicker/timepicker.component.ts	`93.15% <97.5%> (+1.25%)`	⬆️
src/chronos/i18n/pl.ts	`75% <0%> (-2.78%)`	⬇️
src/chronos/i18n/uk.ts	`78.04% <0%> (-2.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465ed0d...cb50a42. Read the comment docs.

YevheniiaMazur · 2018-02-05T15:12:45Z

Tested, looks good

src/spec/timepicker/timepicker-controls.util.spec.ts

 import { TimeChangeEvent, TimepickerComponentState, TimepickerControls } from '../../timepicker/timepicker.models';
+import * as timepickerControlsUtil from '../../timepicker/timepicker-controls.util';


src/spec/timepicker/timepicker.utils.spec.ts

-
-function testTime(hours?: number, minutes?: number, seconds?: number) {
+import { Time, TimepickerComponentState } from '../../timepicker/timepicker.models';
+import * as timepickerUtils from '../../timepicker/timepicker.utils';


src/timepicker/reducer/timepicker.actions.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { Action } from '../../mini-ngrx/index';
+import { Action } from '../../mini-ngrx';


src/timepicker/reducer/timepicker.reducer.ts

@@ -1,4 +1,4 @@
-import { Action } from '../../mini-ngrx/index';


src/timepicker/reducer/timepicker.store.ts

-import { Action } from '../../mini-ngrx/index';
-import { MiniStore } from '../../mini-ngrx/store.class';
-import { MiniState } from '../../mini-ngrx/state.class';
+import { Action, MiniStore, MiniState } from '../../mini-ngrx';


src/timepicker/timepicker.component.html

    <!-- increment hours button-->
    <td>
-      <a class="btn btn-link" [class.disabled]="!canIncrementHours"
+      <a class="btn btn-link" [class.disabled]="!canIncrementHours || !isActive()"


src/timepicker/timepicker.component.ts


  // ui variables
  hours: string;
  minutes: string;
  seconds: string;
  meridian: string;

-  get isSpinnersVisible(): boolean {


src/timepicker/timepicker.component.ts

+    this.invalidSeconds = false;
+  }
+
+  isActive() {


valorkin · 2018-02-06T16:47:11Z

@IlyaSurmay please check my comments
@IraErshova don't forget to rebase you changes

Add validation for timepicker based on ui-bootstrap validation. Fix min-max validation issue. close valor-software#3549 valor-software#3288

…ftware#3602 Add ability to set readonly/disabled state Add disabled demo Fix bud related to highlight input in readonly mood Extend test for timepicker Close valor-software#3602 valor-software#3371

IraErshova force-pushed the feat-timepicker-disabled-state branch from 3e5fc5a to 61f76d7 Compare February 1, 2018 09:52

IraErshova force-pushed the feat-timepicker-disabled-state branch from 61f76d7 to 1459aea Compare February 1, 2018 10:20

IlyaSurmay previously approved these changes Feb 1, 2018

View reviewed changes

IlyaSurmay added comp(timepicker) ready for tests labels Feb 1, 2018

EvilAlexei requested a review from valorkin February 1, 2018 10:55

YevheniiaMazur added in test and removed ready for tests labels Feb 5, 2018

YevheniiaMazur added state: tested ready for merge and removed in test state: tested labels Feb 5, 2018

valorkin requested changes Feb 6, 2018

View reviewed changes

valorkin added needs fix and removed ready for merge labels Feb 6, 2018

IraErshova dismissed IlyaSurmay’s stale review via 5bd0fad February 7, 2018 13:21

IraErshova force-pushed the feat-timepicker-disabled-state branch 2 times, most recently from 5bd0fad to d7ad6cd Compare February 7, 2018 13:25

feat(timepicker): add validation for timepicker

23451f4

Add validation for timepicker based on ui-bootstrap validation. Fix min-max validation issue. close valor-software#3549 valor-software#3288

IraErshova force-pushed the feat-timepicker-disabled-state branch from d7ad6cd to 22db077 Compare February 8, 2018 13:30

feat(timepicker): Add ability to set readonly/disabled state valor-so…

cb50a42

…ftware#3602 Add ability to set readonly/disabled state Add disabled demo Fix bud related to highlight input in readonly mood Extend test for timepicker Close valor-software#3602 valor-software#3371

IraErshova force-pushed the feat-timepicker-disabled-state branch from 22db077 to cb50a42 Compare February 13, 2018 12:39

IlyaSurmay added needs review and removed needs fix labels Feb 13, 2018

valorkin approved these changes Mar 1, 2018

View reviewed changes

valorkin merged commit 4e5f828 into valor-software:development Mar 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(timepicker): Add ability to set readonly/disabled state #3602 #3611

feat(timepicker): Add ability to set readonly/disabled state #3602 #3611

IraErshova commented Feb 1, 2018 •

edited

codecov bot commented Feb 1, 2018 •

edited

YevheniiaMazur commented Feb 5, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

valorkin commented Feb 6, 2018

		import { TimeChangeEvent, TimepickerComponentState, TimepickerControls } from '../../timepicker/timepicker.models';
		import * as timepickerControlsUtil from '../../timepicker/timepicker-controls.util';

		@@ -1,4 +1,4 @@
		import { Action } from '../../mini-ngrx/index';

feat(timepicker): Add ability to set readonly/disabled state #3602 #3611

feat(timepicker): Add ability to set readonly/disabled state #3602 #3611

Conversation

IraErshova commented Feb 1, 2018 • edited

codecov bot commented Feb 1, 2018 • edited

Codecov Report

YevheniiaMazur commented Feb 5, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

valorkin commented Feb 6, 2018

IraErshova commented Feb 1, 2018 •

edited

codecov bot commented Feb 1, 2018 •

edited