Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioning): fix a case of looping #5253

Merged
merged 2 commits into from Jun 7, 2019
Merged

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Jun 7, 2019

Closes #5194
Closes #5231

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #5253 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5253   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bc6f8...6974e64. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #5253 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5253   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bc6f8...6974e64. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

Smoke tested dropdown with tooltips and buttons with tooltips, looks good.

@ABugajska
Copy link

ABugajska commented Feb 18, 2020

I've updated my app to angular 9.0.1 with ngx-bootstrap5.3.4
Bug still occurs with datepickers.
Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop if using tooltip inside dropdown Typehead and tabs crash app
3 participants