Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapse): fix collapse animation (child height) #5316

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Jul 8, 2019

Closes #5202

123-2

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #5316 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5316   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c102ff0...a81c312. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #5316 into development will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #5316     +/-   ##
==============================================
+ Coverage        51.04%   51.54%   +0.5%     
==============================================
  Files                3        3             
  Lines               96       97      +1     
  Branches            17       17             
==============================================
+ Hits                49       50      +1     
  Misses              37       37             
  Partials            10       10
Impacted Files Coverage Δ
demo/src/polyfills.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c102ff0...fa24167. Read the comment docs.

@Domainv Domainv force-pushed the fix-collapse-animation-resize-group branch from 471aa48 to 96503d0 Compare July 9, 2019 12:13
@ludmilanesvitiy
Copy link
Contributor

Tested functionality: accordion inside accordion with animation, collapse inside an accordion, typeahead inside an accordion with animation - looks good. Fixed CY test and stackblitz example.

@Domainv Domainv merged commit f550605 into development Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-collapse-animation-resize-group branch July 9, 2019 13:57
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
…5316)

* fix(collapse): fix collapse animation (child height)

* fix(tests): add fix for cy tests and fix for stackblitz example in IE
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
…5316)

* fix(collapse): fix collapse animation (child height)

* fix(tests): add fix for cy tests and fix for stackblitz example in IE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated accordion doesn't resize group height if content height changes
2 participants