Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): change the mouse event to dismiss a modal on backdrop click #5326

Merged
merged 5 commits into from
Jan 20, 2020
Merged

fix(modal): change the mouse event to dismiss a modal on backdrop click #5326

merged 5 commits into from
Jan 20, 2020

Commits on Jul 12, 2019

  1. fix(modal): change the mouse event to dismiss a modal on backdrop click 

    Because of the use of a 'click' event to trigger the dismissal of a modal, the target of the event doesn't take into account an eventual movement of the mouse before releasing click (for ex. selection of text), which can lead to unwanted dismissal of the modal.

Closes: valor-software#5264
    @florenthobein
    florenthobein committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    4dfc475 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. fix(modal): change the mouse event to dismiss a modal from a directive 

    Because of the use of a 'click' event to trigger the dismissal of a modal, the target of the event doesn't take into account an eventual movement of the mouse before releasing click (for ex. selection of text), which can lead to unwanted dismissal of the modal.
    @florenthobein
    florenthobein committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b1c292b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Merge branch 'development' into modal-dismiss-event

    @daniloff200
    daniloff200 committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    479df6b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Merge branch 'development' into modal-dismiss-event

    @valorkin
    valorkin committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    a134be4 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Merge branch 'development' into modal-dismiss-event

    @dmitry-zhemchugov
    dmitry-zhemchugov committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    4a1af09 View commit details
    Browse the repository at this point in the history