Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setter var active #6435

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

samshay
Copy link
Contributor

@samshay samshay commented Feb 18, 2022

Hy,

This PR fix a problem with this commit ceccdcac1de4316cc33a1067d604a6470c0245ba in file typeahead.directive.ts

In this commit, a function setActive is used to modify variable active, but an existing setter exist in the class.
I delete the function setActive and replace the set of var active with the setter.

It's possible to add this fix to the version 7. Because the accessibility of typeahead without the fix is bad.

Thanks.

Error in commit ceccdca
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #6435 (94c6df5) into development (3e818fd) will increase coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head 94c6df5 differs from pull request most recent head 3f33cd1. Consider uploading reports for the commit 3f33cd1 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6435      +/-   ##
===============================================
+ Coverage        75.89%   75.93%   +0.03%     
===============================================
  Files              315      315              
  Lines            10642    10640       -2     
  Branches          2935     2935              
===============================================
+ Hits              8077     8079       +2     
+ Misses            2564     2560       -4     
  Partials             1        1              
Impacted Files Coverage Δ
src/typeahead/typeahead-container.component.ts 84.86% <87.50%> (+4.11%) ⬆️
src/chronos/i18n/pl.ts 81.96% <0.00%> (-6.56%) ⬇️
src/chronos/i18n/sk.ts 85.00% <0.00%> (-1.25%) ⬇️
src/chronos/i18n/cs.ts 87.36% <0.00%> (-1.06%) ⬇️
src/typeahead/typeahead.directive.ts 84.98% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e818fd...3f33cd1. Read the comment docs.

@cypress
Copy link

cypress bot commented Feb 18, 2022



Test summary

800 32 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 94c6df5 ℹ️
Started Feb 18, 2022 5:19 PM
Ended Feb 18, 2022 6:01 PM
Duration 42:12 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 32 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant