fix(modal): fix the closure of modal when clicking of scrollbar in so… #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix that #6023 (comment) but for version v6.2.0
With some combinations of browser & OS (for ex Chrome 87 on MacOS) the scrollbar can appear above the content, and the events mousedown & mouseup will fire when clicking on it, which triggers the closure of the modal.
As click doesn't fire if we click on the scrollbar, replacing mouseup by click solves the issue (the use of mousedown being necessary to fix an other issue about text selection).
Creating tests for this scenario is complicated as the bug appears on specific browsers.
Fixes #5893 and #5810
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.