chore: angular 17 migration #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated @nx/* and @angular/* family to their latest versions - updated via migrations - regenerated package-lock.json and now it uses v3 format - docs polyfills used old `dist` imports, replaced it to `plugins` - updated README.md, mentioning that next major version will require/support Angular 17 - removed unused variables from tests to fight eslint errors BREAKING CHANGE: Angular 17 is required now
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #6621 +/- ##
===============================================
+ Coverage 76.83% 76.91% +0.07%
===============================================
Files 315 315
Lines 10682 10668 -14
Branches 2786 2848 +62
===============================================
- Hits 8208 8205 -3
+ Misses 2473 2462 -11
Partials 1 1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
valorkin
approved these changes
Nov 28, 2023
|
Hi, was this deployed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
closes #6618
Description
updated @nx/* and @angular/* family to their latest versions
updated via migrations
regenerated package-lock.json and now it uses v3 format
docs polyfills used old
distimports, replaced it topluginsupdated README.md, mentioning that next major version will require/support Angular 17
fixed eslint issues
deprecated
AvailbleBSPositions, it had a grammar mistake. Rewrote underlyingAvailableBSPositionsto use template types to make it more easy to understandfixed prettier config and launched nx formatting
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.