Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 2 rc.4 and @angular/forms #678

Merged
merged 3 commits into from
Jul 5, 2016
Merged

Angular 2 rc.4 and @angular/forms #678

merged 3 commits into from
Jul 5, 2016

Conversation

jFensch
Copy link

@jFensch jFensch commented Jul 1, 2016

Tests are now failing to due to breaking changes in RC.4 testing APIs. Any help tracking down resolutions would be greatly appreciated.

@jFensch
Copy link
Author

jFensch commented Jul 1, 2016

@Dinistro @valorkin Could really use some help fixing these tests. RC.4 breaking changes really made a mess.

@Dinistro
Copy link
Contributor

Dinistro commented Jul 1, 2016

@jFensch I'm sorry, I need to finish something at work and I have finals next week.

@jFensch
Copy link
Author

jFensch commented Jul 1, 2016

Tests have been updated to resolve RC.4 breaking changes. I'm not sure what's failing in the button tests - updated NgModel provider from @angular/forms should be available in the test context. Have excluded for now.

Should resolve #627

@valorkin
Copy link
Member

valorkin commented Jul 2, 2016

@otelnov can you please help with updating tests?

@adrianfaciu
Copy link

What is the status with this pull request ? Can we help in any way ? Kindof a blocker for projects updated to RC.4.

@valorkin
Copy link
Member

valorkin commented Jul 5, 2016

@adrianfaciu @otelnov is working on fixing tests and travis build

@otelnov otelnov merged commit cfbdff7 into valor-software:development Jul 5, 2016
@valorkin
Copy link
Member

valorkin commented Jul 5, 2016

Thanks!

@omargon
Copy link

omargon commented Jul 6, 2016

Hi, when will this fix update be available via NPM? And/or is there another way I can include it on my project? I tried npm install from github via npm install --save https://github.com/valor-software/ng2-bootstrap.git but was getting the following error message when building app after it error TS2307: Cannot find module 'ng2-bootstrap'.

@adrianfaciu
Copy link

@omargon You can clone the repo and do a compile (flow.compile). Then you can either use npm install with the folder or do an npm pack and install from the tarball.

@PRR24
Copy link

PRR24 commented Jul 7, 2016

Is it also expected to solve pagination "ORIGINAL EXCEPTION: No value accessor for ''" issue?
If yes, would be awesome to have the "official" npm package soon.

@Dinistro
Copy link
Contributor

Dinistro commented Jul 7, 2016

@PRR24 Yes it does.
@valorkin When do you plan to release this?

@hxlniada
Copy link

hxlniada commented Jul 8, 2016

@valorkin When do you plan to release this? It's really a blockr

@superdem
Copy link

superdem commented Jul 12, 2016

Hi @valorkin I updated the ng2-bootstrap to v1.0.19 and also angular RC. 4 but it still gives an error like "No provider for NgModel".
Do you have any suggestion for this ?

@Dinistro
Copy link
Contributor

@superdem Did you disable the old forms?

More infos here: #722 (comment)

@superdem
Copy link

@Dinistro Yes,thats the point!
Thank you

@Slavrix
Copy link

Slavrix commented Aug 4, 2016

I've got an issue with the datepicker, im getting

No provider for NgModel ("StartDatepicker">
[ERROR ->]<datepicker [(ngModel)]='start' datepickerMode='day' minMode='day' maxMode='year' [minDate]='today'

Im using ng2-bootstrap:1.0.24
angular2 RC4
ive got the disableDeprecatedForms(), provideForms(),
in my bootstrap already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants