feat: allow Eth selection in the send flow #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wallet into jophish/multi-chain-balances
MuckT
changed the title
cajubelt
reviewed
Oct 10, 2023
| @@ -64,9 +64,9 @@ function useTransactionCallbacks({ | |||
| inputAmount: inputIsInLocalCurrency ? localAmount! : tokenAmount, | |||
| tokenAmount, | |||
| amountIsInLocalCurrency: inputIsInLocalCurrency, | |||
| tokenAddress: transferTokenAddress, | |||
| tokenAddress: tokenInfo!.address!, | |||
Co-authored-by: Charlie Andrews-Jubelt <cajubelt@users.noreply.github.com>
This reverts commit 63489ef.
# Conflicts: # src/tokens/selectors.test.ts
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2024
### Description This was added in #4242 when we were working towards multichain, but now there shouldn't be a need for multiple TokenBalance types ### Test plan CI ### Related issues N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the selection of Eth in the send flow and the use of the Max button while preserving functionality of the existing Celo send flow.
Video
Screen.Recording.2023-09-29.at.3.28.02.PM.mov
Test plan
Prod Multichain Testerssegment in Statsig.Related issues
Backwards compatibility
Yes