Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(token-bottom-sheet): remove unused generic #5484

Merged
merged 1 commit into from
May 28, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

This was added in #4242 when we were working towards multichain, but now there shouldn't be a need for multiple TokenBalance types

Test plan

CI

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (a012a8d) to head (2b742e9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5484      +/-   ##
==========================================
- Coverage   86.40%   86.39%   -0.01%     
==========================================
  Files         761      761              
  Lines       31359    31359              
  Branches     5389     5389              
==========================================
- Hits        27097    27094       -3     
- Misses       4031     4034       +3     
  Partials      231      231              
Files Coverage Δ
src/components/TokenBottomSheet.tsx 95.41% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a012a8d...2b742e9. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit a02e912 May 28, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/clean-token-bottom-sheet-2 branch May 28, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants