refactor: make dynamic links methods more reusable, for jumpstart #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build had no size change
Celo (test) 1.79.0 (144)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
==========================================
- Coverage 85.46% 85.44% -0.03%
==========================================
Files 719 720 +1
Lines 29347 29432 +85
Branches 5091 5099 +8
==========================================
+ Hits 25082 25148 +66
- Misses 4026 4045 +19
Partials 239 239
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dievazqu
approved these changes
Feb 28, 2024
src/invite/Invite.test.tsx
Outdated
| import { createMockStore } from 'test/utils' | ||
| import Invite from './Invite' | ||
|
|
||
| jest.mock('src/analytics/ValoraAnalytics') | ||
| const mockShare = jest.spyOn(Share, 'share') | ||
| const mockedCreateDynamicLink = jest.spyOn(InviteUtils, 'createDynamicLink') | ||
| const mockedCreateDynamicLink = jest.spyOn(InviteUtils, 'createInviteLink') |
There was a problem hiding this comment.
Suggested change
| const mockedCreateDynamicLink = jest.spyOn(InviteUtils, 'createInviteLink') | |
| const mockedCreateInviteLink = jest.spyOn(InviteUtils, 'createInviteLink') |
auto-merge was automatically disabled
February 28, 2024 23:53
Merge queue setting changed
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…lora-inc#4995) ### Description As the title. ### Test plan n/a ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added) --------- Co-authored-by: Tom McGuire <Mcgtom10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: