Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nft gallery and old token details #5016

Merged
merged 25 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
0303a66
chore: remove old token balance screen
MuckT Feb 29, 2024
10cccc8
chore: remove nft gallery screen
MuckT Feb 29, 2024
fe747e0
chore: remove unused view_nft_home_assets
MuckT Feb 29, 2024
e2af517
chore: remove show asset details screen statsig feature gate
MuckT Feb 29, 2024
419f1b7
chore: remove show in app nft viewer and show in app nft gallery feat…
MuckT Feb 29, 2024
a13c34e
Merge branch 'main' into tomm/act-1074
MuckT Feb 29, 2024
9a49272
fix: remove unused event, screen and type
MuckT Feb 29, 2024
2a64297
chore: update root state schema
MuckT Feb 29, 2024
ec6dd4b
Merge branch 'main' into tomm/act-1074
MuckT Mar 1, 2024
0838a89
test: update nft feed item tests for feature gate removal
MuckT Mar 1, 2024
0fb5770
test: update nft saga tests for feature gate removal
MuckT Mar 1, 2024
5145410
fix: make fiat exchange and home token balances behavior consistent
MuckT Mar 1, 2024
f42ac27
test: update token balance tests for feature flag and behavior alignment
MuckT Mar 1, 2024
09c020c
Merge branch 'main' into tomm/act-1074
MuckT Mar 2, 2024
4d84eef
Merge branch 'main' into tomm/act-1074
MuckT Mar 4, 2024
eb0e334
Merge branch 'main' into tomm/act-1074
MuckT Mar 4, 2024
4f70905
chore: remove unused screen
MuckT Mar 5, 2024
6fb2c1d
test: adjust mocking of feature gate
MuckT Mar 5, 2024
3a38b24
Merge branch 'main' into tomm/act-1074
MuckT Mar 5, 2024
62c8ea5
chore: restore FiatExchangeTokenBalance behavior
MuckT Mar 5, 2024
99c38dc
test: split out test cases for separate components where needed
MuckT Mar 5, 2024
93a5631
chore: update root state schema
MuckT Mar 5, 2024
047325d
test: remove it.each for single test case
MuckT Mar 5, 2024
fcedcf6
test: remove unused mocked feature gate
MuckT Mar 5, 2024
0459fa9
test(token-balances): clean-up and ensuring feature flags are set
MuckT Mar 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions e2e/src/usecases/Assets.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ export default Assets = () => {
await device.installApp()
await launchApp({
newInstance: true,
launchArgs: {
// NFT flag must also be true, otherwise Collectibles tab show an empty screen
statsigGateOverrides: `show_asset_details_screen=true,show_in_app_nft_gallery=true`,
},
permissions: { notifications: 'YES', contacts: 'YES', camera: 'YES' },
})
let mnemonic = SAMPLE_BACKUP_KEY
Expand Down
2 changes: 0 additions & 2 deletions src/analytics/Events.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export enum HomeEvents {
transaction_feed_item_select = 'transaction_feed_item_select',
transaction_feed_address_copy = 'transaction_feed_address_copy',
view_token_balances = 'view_token_balances',
view_nft_home_assets = 'view_nft_home_assets',
home_action_pressed = 'home_action_pressed',
notification_bell_pressed = 'notification_bell_pressed',
notification_center_opened = 'notification_center_opened',
Expand Down Expand Up @@ -614,7 +613,6 @@ export enum AssetsEvents {
export enum NftEvents {
nft_error_screen_open = 'nft_error_screen_open',
nft_media_load = 'nft_media_load',
nft_gallery_screen_open = 'nft_gallery_screen_open',
}

export enum BuilderHooksEvents {
Expand Down
4 changes: 0 additions & 4 deletions src/analytics/Properties.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ interface HomeEventsProperties {
[HomeEvents.transaction_feed_item_select]: undefined
[HomeEvents.transaction_feed_address_copy]: undefined
[HomeEvents.view_token_balances]: { totalBalance?: string }
[HomeEvents.view_nft_home_assets]: undefined
[HomeEvents.home_action_pressed]: { action: HomeActionName }
[HomeEvents.notification_bell_pressed]: { hasNotifications: boolean }
[HomeEvents.notification_center_opened]: { notificationsCount: number }
Expand Down Expand Up @@ -1440,9 +1439,6 @@ interface NftsEventsProperties {
error?: string
mediaType: 'image' | 'video'
}
[NftEvents.nft_gallery_screen_open]: {
numNfts: number
}
}

interface BuilderHooksProperties {
Expand Down
4 changes: 2 additions & 2 deletions src/analytics/docs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const eventDocs: Record<AnalyticsEventType, string> = {
[HomeEvents.transaction_feed_item_select]: ``,
[HomeEvents.transaction_feed_address_copy]: ``,
[HomeEvents.view_token_balances]: ``,
[HomeEvents.view_nft_home_assets]: `When "NFTs" is clicked in Home Assets Pages`,
[HomeEvents.home_action_pressed]: ``,
[HomeEvents.notification_bell_pressed]: ``,
[HomeEvents.hide_balances]: `When the eye icon is clicked to hide balances on the home screen`,
Expand Down Expand Up @@ -528,7 +527,6 @@ export const eventDocs: Record<AnalyticsEventType, string> = {
[AssetsEvents.import_token_error]: `When a user enters token address and validation fails in the Import Token screen`,
[NftEvents.nft_error_screen_open]: `When the high level error screen is mounted`,
[NftEvents.nft_media_load]: `When attempting to load NFT media`,
[NftEvents.nft_gallery_screen_open]: `When the gallery screen is mounted`,
[BuilderHooksEvents.hooks_enable_preview_propose]: `When a user scans a QR code or opens a deep link to enable hooks preview`,
[BuilderHooksEvents.hooks_enable_preview_cancel]: `When a user cancels the hooks preview flow`,
[BuilderHooksEvents.hooks_enable_preview_confirm]: `When a user confirms enabling hooks preview`,
Expand All @@ -554,6 +552,7 @@ export const eventDocs: Record<AnalyticsEventType, string> = {
// Legacy event docs
// The below events had docs, but are no longer produced by the latest app version.
// [HomeEvents.home_send]: `when "send" button is pressed from home screen send or request bar (NOT from home screen actions)`,
// [HomeEvents.view_nft_home_assets]: `When "NFTs" is clicked in Home Assets Pages`,
// [DappExplorerEvents.dapp_open_info]: `when a user taps on the help icon`,
// [DappExplorerEvents.dapp_open_more_info]: `when a user taps on the "more" button from inside the help bottom sheet`,
// [DappExplorerEvents.dapp_search]: `when a user searches on the dapp explorer screen`,
Expand All @@ -564,6 +563,7 @@ export const eventDocs: Record<AnalyticsEventType, string> = {
// [CeloExchangeEvents.celo_withdraw_cancel]: `when ’cancel’ is clicked on the review screen`,
// [CeloExchangeEvents.celo_withdraw_confirm]: `when ‘withdraw’ is clicked on the review screen`,
// [CeloExchangeEvents.celo_withdraw_error]: `when there's an error on the withdrawal transaction`,
// [NftEvents.nft_gallery_screen_open]: `When the gallery screen is mounted`,
// [PhoneVerificationEvents.phone_verification_input_help_skip]: `when the user presses skip on the help dialog to skip verification`,
// [PhoneVerificationEvents.phone_verification_skip]: `when skip is pressed in the phone number input screen`,
// [IdentityEvents.contacts_connect]: `when connect button is pressed`,
Expand Down