chore: remove nft gallery and old token details #5016

MuckT · 2024-02-29T22:54:08Z

Description

Cleanup of old Nft Gallery feature now handled in Assets and of the old token balances screen also now handled in assets. Additionally the following feature flags which have been rolled out to 100% were removed: show_in_app_nft_gallery, show_in_app_nft_viewer, view_nft_home_assets and show_asset_details_screen.

Test plan

Tested locally on iOS
E2E tests passing

Related issues

Fixes ACT-1074

Backwards compatibility

Yes

Network scalability

Yes

…ure gates

MuckT · 2024-03-01T21:13:12Z

src/components/TokenBalance.tsx

  }

  return (
    <View style={styles.container} testID="FiatExchangeTokenBalance">
      <View style={styles.titleExchange}>
        <View style={styles.row}>
-          {tokenBalances.length > 1 ? (


This behavior was updated because the tests were coupled together. Now the behavior of the home token balances and the fiat exchange token balances matches.

Does this need to be updated? Seems like the original intent is to not make it a touchable because there's only one token and there's no need for the user to go to the assets screen to view the breakdown

If we want to change this behavior, I'd do this in a separate PR.

The behavior is different when show_asset_details_screen was set to true which is 100%. If we want to keep the behavior of the existing FiatExchangeTokenBalance some tests will need to be updated. Due to the coupled testing it was unclear if we ever expected these two components to diverge in behavior like they have.

I believe the FiatExchangeTokenBalance behavior has always been different from the HomeTokenBalance behavior.
FiatExchangeTokenBalance shows the ViewBalances touchable if num tokens > 1 both before and after the asset details change. HomeTokenBalance before asset details only included the ViewBalances touchable if num tokens >= 1 and after asset details, it is always included (since we also show tokens with zero balance in the assets screen).

I think we had coupled tests prior just because the case for 0 tokens overlapped. Can't we just drop the it.each and just keep the test for FiatExchangeTokenBalance and keep this test for HomeTokenBalance and just remove the feature gate in the name and mocks? No new tests need to be added as part of this change.

Fixed in 62c8ea5 and tests updated in 99c38dc!

MuckT · 2024-03-01T21:14:31Z

src/components/TokenBalance.test.tsx

-      .mockImplementation(
-        (featureGate) => featureGate !== StatsigFeatureGates.SHOW_ASSET_DETAILS_SCREEN
-      )
+    jest.mocked(getFeatureGate).mockImplementation(() => true)


This is controlling multiple features flags. Open to other options on how to handle this.

Seems like the TokenBalance.tsx only references SHOW_HIDE_HOME_BALANCES_TOGGLE gate now that the SHOW_ASSET_DETAILS_SCREEN gate is removed?
Could change this and all below references to this (and just update true / false appropriately)

Suggested change

jest.mocked(getFeatureGate).mockImplementation(() => true)

jest.mocked(getFeatureGate).mockReturnValue(true)

Fixed in 6fb2c1d!

emerge-tools · 2024-03-01T21:18:23Z

1 build decreased size

Name	Version	Download	Change	Install	Change	Approval
Celo (test) org.celo.mobile.test	1.79.0 (144)	24.2 MB	⬇️ 2.6 kB (-0.01%)	60.3 MB	⬇️ 12.3 kB (-0.02%)	N/A

Celo (test) 1.79.0 (144)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 12.3 kB (-0.02%)
Total download size change: ⬇️ 2.6 kB (-0.01%)

Largest size changes

Item	Install Size Change
main.jsbundle	⬇️ -12.3 kB

🛸 Powered by Emerge Tools

codecov · 2024-03-01T21:19:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (363f7f6) to head (0459fa9).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5016      +/-   ##
==========================================
- Coverage   85.48%   85.46%   -0.03%     
==========================================
  Files         723      719       -4     
  Lines       29437    29199     -238     
  Branches     5099     5038      -61     
==========================================
- Hits        25165    24955     -210     
+ Misses       4037     4014      -23     
+ Partials      235      230       -5

Files	Coverage Δ
src/analytics/Events.tsx	`100.00% <ø> (ø)`
src/analytics/Properties.tsx	`100.00% <ø> (ø)`
src/components/TokenBalance.tsx	`97.88% <100.00%> (-0.16%)`	⬇️
src/navigator/DrawerNavigator.tsx	`93.79% <ø> (+1.15%)`	⬆️
src/navigator/Screens.tsx	`100.00% <ø> (ø)`
src/nfts/saga.ts	`91.30% <ø> (-0.48%)`	⬇️
src/nfts/types.ts	`100.00% <ø> (ø)`
src/statsig/constants.ts	`100.00% <ø> (ø)`
src/statsig/types.ts	`100.00% <ø> (ø)`
src/transactions/feed/NftFeedItem.tsx	`88.23% <100.00%> (-7.12%)`	⬇️

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363f7f6...0459fa9. Read the comment docs.

satish-ravi · 2024-03-04T21:49:24Z

src/components/TokenBalance.test.tsx

-      .mockImplementation(
-        (featureGate) => featureGate !== StatsigFeatureGates.SHOW_ASSET_DETAILS_SCREEN
-      )
+    jest.mocked(getFeatureGate).mockImplementation(() => true)


Seems like the TokenBalance.tsx only references SHOW_HIDE_HOME_BALANCES_TOGGLE gate now that the SHOW_ASSET_DETAILS_SCREEN gate is removed?
Could change this and all below references to this (and just update true / false appropriately)

Suggested change

jest.mocked(getFeatureGate).mockImplementation(() => true)

jest.mocked(getFeatureGate).mockReturnValue(true)

satish-ravi · 2024-03-04T21:52:29Z

src/components/TokenBalance.tsx

  }

  return (
    <View style={styles.container} testID="FiatExchangeTokenBalance">
      <View style={styles.titleExchange}>
        <View style={styles.row}>
-          {tokenBalances.length > 1 ? (


Does this need to be updated? Seems like the original intent is to not make it a touchable because there's only one token and there's no need for the user to go to the assets screen to view the breakdown

If we want to change this behavior, I'd do this in a separate PR.

src/navigator/Screens.tsx

satish-ravi · 2024-03-05T20:12:12Z

src/components/TokenBalance.test.tsx

-  )
-
-  it.each([HomeTokenBalance, FiatExchangeTokenBalance])(
+  it.each([HomeTokenBalance])(


Since this applies to only home token balance, can we move this to its own
describe section? This would also allow us to change the it.each to a
describe.each so we don't end up adding tests in this section that
only applies to one of them?

Fixed in 047325d!

satish-ravi · 2024-03-05T20:12:52Z

src/components/TokenBalance.test.tsx

+describe('FiatExchangeTokenBalance', () => {
+  beforeEach(() => {
+    jest.clearAllMocks()
+    jest.mocked(getFeatureGate).mockReturnValue(true)


is this required? this component doesn't use a feature gate right?

This started failing when I removed the feature gate.

Ah, looks like this is needed for positions to be included. I think we also need this for the describe('FiatExchangeTokenBalance and HomeTokenBalance') section too. I think they currently pass from a stray mock from another describe. We should add that back, because I think running them standalone would fail

src/components/TokenBalance.test.tsx

satish-ravi

A once getFeatureGate mock is added

satish-ravi · 2024-03-06T05:55:18Z

src/components/TokenBalance.test.tsx

+describe('FiatExchangeTokenBalance', () => {
+  beforeEach(() => {
+    jest.clearAllMocks()
+    jest.mocked(getFeatureGate).mockReturnValue(true)


Ah, looks like this is needed for positions to be included. I think we also need this for the describe('FiatExchangeTokenBalance and HomeTokenBalance') section too. I think they currently pass from a stray mock from another describe. We should add that back, because I think running them standalone would fail

satish-ravi · 2024-03-06T05:55:41Z

src/components/TokenBalance.test.tsx

@@ -737,6 +419,262 @@ describe('FiatExchangeTokenBalance and HomeTokenBalance', () => {
  })
 })

+describe('FiatExchangeTokenBalance and HomeTokenBalance', () => {


nit: can we just do a describe.each and drop the it.each everywhere else?

Fixed in 0459fa9!

### Description Cleanup of old Nft Gallery feature now handled in Assets and of the old token balances screen also now handled in assets. Additionally the following feature flags which have been rolled out to 100% were removed: `show_in_app_nft_gallery`, `show_in_app_nft_viewer`, `view_nft_home_assets` and `show_asset_details_screen`. ### Test plan - Tested locally on iOS - E2E tests passing ### Related issues - Fixes ACT-1074 ### Backwards compatibility Yes ### Network scalability Yes

MuckT and others added 13 commits February 29, 2024 14:22

chore: remove old token balance screen

0303a66

chore: remove nft gallery screen

10cccc8

chore: remove unused view_nft_home_assets

fe747e0

chore: remove show asset details screen statsig feature gate

e2af517

chore: remove show in app nft viewer and show in app nft gallery feat…

419f1b7

…ure gates

Merge branch 'main' into tomm/act-1074

a13c34e

fix: remove unused event, screen and type

9a49272

chore: update root state schema

2a64297

Merge branch 'main' into tomm/act-1074

ec6dd4b

test: update nft feed item tests for feature gate removal

0838a89

test: update nft saga tests for feature gate removal

0fb5770

fix: make fiat exchange and home token balances behavior consistent

5145410

test: update token balance tests for feature flag and behavior alignment

f42ac27

MuckT commented Mar 1, 2024

View reviewed changes

MuckT marked this pull request as ready for review March 1, 2024 21:17

MuckT added 3 commits March 1, 2024 16:28

Merge branch 'main' into tomm/act-1074

09c020c

Merge branch 'main' into tomm/act-1074

4d84eef

Merge branch 'main' into tomm/act-1074

eb0e334

satish-ravi reviewed Mar 4, 2024

View reviewed changes

MuckT added 6 commits March 4, 2024 20:07

chore: remove unused screen

4f70905

test: adjust mocking of feature gate

6fb2c1d

Merge branch 'main' into tomm/act-1074

3a38b24

chore: restore FiatExchangeTokenBalance behavior

62c8ea5

test: split out test cases for separate components where needed

99c38dc

chore: update root state schema

93a5631

satish-ravi reviewed Mar 5, 2024

View reviewed changes

src/components/TokenBalance.test.tsx Show resolved Hide resolved

MuckT added 2 commits March 5, 2024 13:29

test: remove it.each for single test case

047325d

test: remove unused mocked feature gate

fcedcf6

satish-ravi approved these changes Mar 6, 2024

View reviewed changes

test(token-balances): clean-up and ensuring feature flags are set

0459fa9

MuckT enabled auto-merge March 6, 2024 19:21

MuckT added this pull request to the merge queue Mar 6, 2024

Merged via the queue into main with commit 4df1078 Mar 6, 2024
16 checks passed

MuckT deleted the tomm/act-1074 branch March 6, 2024 20:00

satish-ravi mentioned this pull request Mar 7, 2024

refactor(tokens): break out AssetTabBar and AssetList into its own components #5056

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove nft gallery and old token details #5016

chore: remove nft gallery and old token details #5016

MuckT commented Feb 29, 2024 •

edited

MuckT Mar 1, 2024

satish-ravi Mar 4, 2024

MuckT Mar 5, 2024

satish-ravi Mar 5, 2024 •

edited

MuckT Mar 5, 2024

MuckT Mar 1, 2024

satish-ravi Mar 4, 2024

MuckT Mar 5, 2024

emerge-tools bot commented Mar 1, 2024 •

edited

codecov bot commented Mar 1, 2024 •

edited

satish-ravi Mar 4, 2024

satish-ravi Mar 4, 2024

satish-ravi Mar 5, 2024

MuckT Mar 5, 2024 •

edited

satish-ravi Mar 5, 2024

MuckT Mar 5, 2024

satish-ravi Mar 6, 2024

satish-ravi left a comment

satish-ravi Mar 6, 2024

satish-ravi Mar 6, 2024

MuckT Mar 6, 2024

	jest.mocked(getFeatureGate).mockImplementation(() => true)
	jest.mocked(getFeatureGate).mockReturnValue(true)

chore: remove nft gallery and old token details #5016

chore: remove nft gallery and old token details #5016

Conversation

MuckT commented Feb 29, 2024 • edited

Description

Test plan

Related issues

Backwards compatibility

Network scalability

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satish-ravi Mar 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emerge-tools bot commented Mar 1, 2024 • edited

1 build decreased size

Celo (test) 1.79.0 (144)org.celo.mobile.test

codecov bot commented Mar 1, 2024 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MuckT Mar 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satish-ravi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MuckT commented Feb 29, 2024 •

edited

satish-ravi Mar 5, 2024 •

edited

emerge-tools bot commented Mar 1, 2024 •

edited

Celo (test) 1.79.0 (144)
org.celo.mobile.test

codecov bot commented Mar 1, 2024 •

edited

MuckT Mar 5, 2024 •

edited