chore: remove nft gallery and old token details #5016
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,14 +211,7 @@ export function AssetsTokenBalance({ showInfo }: { showInfo: boolean }) { | |
| </TouchableOpacity> | ||
| )} | ||
| </View> | ||
| <TokenBalance style={styles.totalBalance} singleTokenViewEnabled={false} /> | ||
|
|
||
| {shouldRenderInfoComponent && ( | ||
| <Animated.View style={[styles.totalAssetsInfoContainer, animatedStyles]}> | ||
|
|
@@ -242,11 +235,7 @@ export function HomeTokenBalance() { | |
| ValoraAnalytics.track(HomeEvents.view_token_balances, { | ||
| totalBalance: totalBalance?.toString(), | ||
| }) | ||
| navigate(Screens.Assets) | ||
| } | ||
|
|
||
| const onCloseDialog = () => { | ||
|
|
@@ -276,20 +265,13 @@ export function HomeTokenBalance() { | |
| > | ||
| {t('whatTotalValue.body')} | ||
| </Dialog> | ||
| <TouchableOpacity style={styles.row} onPress={onViewBalances} testID="ViewBalances"> | ||
| <Text style={styles.viewBalances}>{t('viewBalances')}</Text> | ||
| <ProgressArrow style={styles.arrow} color={Colors.primary} /> | ||
| </TouchableOpacity> | ||
| </View> | ||
| <TokenBalance | ||
| style={styles.totalBalance} | ||
| showHideHomeBalancesToggle={getFeatureGate( | ||
| StatsigFeatureGates.SHOW_HIDE_HOME_BALANCES_TOGGLE | ||
| )} | ||
|
|
@@ -301,31 +283,22 @@ export function HomeTokenBalance() { | |
| export function FiatExchangeTokenBalance() { | ||
| const { t } = useTranslation() | ||
| const totalBalance = useTotalTokenBalance() | ||
|
|
||
| const onViewBalances = () => { | ||
| ValoraAnalytics.track(FiatExchangeEvents.cico_landing_token_balance, { | ||
| totalBalance: totalBalance?.toString(), | ||
| }) | ||
| navigate(Screens.Assets) | ||
| } | ||
|
|
||
| return ( | ||
| <View style={styles.container} testID="FiatExchangeTokenBalance"> | ||
| <View style={styles.titleExchange}> | ||
| <View style={styles.row}> | ||
|
There was a problem hiding this comment. This behavior was updated because the tests were coupled together. Now the behavior of the home token balances and the fiat exchange token balances matches. There was a problem hiding this comment. Does this need to be updated? Seems like the original intent is to not make it a touchable because there's only one token and there's no need for the user to go to the assets screen to view the breakdown There was a problem hiding this comment. The behavior is different when show_asset_details_screen was set to true which is 100%. If we want to keep the behavior of the existing FiatExchangeTokenBalance some tests will need to be updated. Due to the coupled testing it was unclear if we ever expected these two components to diverge in behavior like they have. There was a problem hiding this comment. I believe the FiatExchangeTokenBalance behavior has always been different from the HomeTokenBalance behavior. I think we had coupled tests prior just because the case for 0 tokens overlapped. Can't we just drop the |
||
| <TouchableOpacity style={styles.row} onPress={onViewBalances} testID="ViewBalances"> | ||
| <Text style={styles.exchangeTotalValue}>{t('totalValue')}</Text> | ||
| <ProgressArrow style={styles.exchangeArrow} height={9.62} color={Colors.gray4} /> | ||
| </TouchableOpacity> | ||
| </View> | ||
| </View> | ||
| <TokenBalance style={styles.exchangeBalance} /> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is controlling multiple features flags. Open to other options on how to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the TokenBalance.tsx only references
SHOW_HIDE_HOME_BALANCES_TOGGLEgate now that theSHOW_ASSET_DETAILS_SCREENgate is removed?Could change this and all below references to this (and just update true / false appropriately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6fb2c1d!