feat(home): remove cash in bottom sheet

e2e/src/usecases/Assets.js

@@ -1,12 +1,7 @@
 import { generateMnemonic } from '@celo/cryptographic-utils'
 import { DEFAULT_RECIPIENT_ADDRESS, SAMPLE_BACKUP_KEY } from '../utils/consts'
 import { launchApp } from '../utils/retries'
-import {
-  quickOnboarding,
-  waitForElementByIdAndTap,
-  waitForElementId,
-  dismissCashInBottomSheet,
-} from '../utils/utils'
+import { quickOnboarding, waitForElementByIdAndTap, waitForElementId } from '../utils/utils'
 
 async function validateSendFlow(tokenSymbol) {
   // navigate to send amount screen to ensure the expected token symbol is pre-selected
@@ -86,7 +81,6 @@ export default Assets = () => {
         mnemonic = await generateMnemonic()
       }
       await quickOnboarding(mnemonic)
-      await dismissCashInBottomSheet()
     })
 
     it('navigates to Assets screen from home', async () => {

e2e/src/usecases/FiatConnectTransferOut.js

@@ -4,7 +4,6 @@ import fetch from 'node-fetch'
 import { MOCK_PROVIDER_API_KEY, MOCK_PROVIDER_BASE_URL } from 'react-native-dotenv'
 import { SAMPLE_PRIVATE_KEY } from '../utils/consts'
 import {
-  dismissCashInBottomSheet,
   enterPinUiIfNecessary,
   fundWallet,
   quickOnboarding,
@@ -63,7 +62,6 @@ async function submitTransfer(expectZeroBalance = false) {
 
   // WalletHome
   if (expectZeroBalance) {
-    await dismissCashInBottomSheet()
   }
   await expect(element(by.id('HomeAction-Send'))).toBeVisible() // proxy for reaching home screen, imitating NewAccountOnboarding e2e test
 }

e2e/src/usecases/NewAccountOnboarding.js

@@ -3,7 +3,6 @@ import { EXAMPLE_NAME } from '../utils/consts'
 import { launchApp } from '../utils/retries'
 import {
   completeProtectWalletScreen,
-  dismissCashInBottomSheet,
   enterPinUi,
   quickOnboarding,
   scrollIntoView,
@@ -28,7 +27,6 @@ const quickEducation = async () => {
 
 const arriveAtHomeScreen = async () => {
   // Arrived to Home screen
-  await dismissCashInBottomSheet()
   await expect(element(by.id('HomeAction-Send'))).toBeVisible()
 }
 
@@ -117,7 +115,6 @@ export default NewAccountOnboarding = () => {
       .withTimeout(10 * 1000)
 
     // Navigated to Home screen
-    await dismissCashInBottomSheet()
     await waitFor(element(by.id('HomeAction-Send')))
       .toBeVisible()
       .withTimeout(10 * 1000)

e2e/src/usecases/NewAccountPhoneVerification.js

@@ -7,7 +7,6 @@ import { EXAMPLE_NAME, EXAMPLE_PHONE_NUMBER } from '../utils/consts'
 import { launchApp } from '../utils/retries'
 import { checkBalance, receiveSms } from '../utils/twilio'
 import {
-  dismissCashInBottomSheet,
   enterPinUi,
   scrollIntoView,
   sleep,
@@ -179,7 +178,6 @@ export default NewAccountPhoneVerification = () => {
     await element(by.text('Skip')).tap()
 
     // Assert we've arrived at the home screen
-    await dismissCashInBottomSheet()
     await waitForElementId('HomeAction-Send')
 
     // Assert that 'Connect phone number' is present in settings

e2e/src/utils/retries.js

@@ -1,5 +1,4 @@
 import { retry } from 'ts-retry-promise'
-import { dismissCashInBottomSheet } from './utils'
 
 export const launchApp = async (
   launchArgs = {
@@ -25,7 +24,7 @@ export const launchApp = async (
   })
 }
 
-export const reloadReactNative = async (dismissBottomSheet = true) => {
+export const reloadReactNative = async () => {
   await retry(
     async () => {
       try {
@@ -38,5 +37,4 @@ export const reloadReactNative = async (dismissBottomSheet = true) => {
     },
     { retries: 5, delay: 10 * 1000, timeout: 30 * 10000 }
   )
-  if (dismissBottomSheet) await dismissCashInBottomSheet()
 }

e2e/src/utils/utils.js

@@ -214,7 +214,6 @@ export async function quickOnboarding(mnemonic = SAMPLE_BACKUP_KEY) {
     }
 
     // Assert on Wallet Home Screen
-    await dismissCashInBottomSheet()
     await expect(element(by.id('HomeAction-Send'))).toBeVisible()
   } catch {} // Don't throw an error just silently continue
 }
@@ -342,15 +341,6 @@ export async function confirmTransaction(commentText) {
   }
 }
 
-export async function dismissCashInBottomSheet() {
-  try {
-    await waitFor(element(by.id('CashInBottomSheet')))
-      .toBeVisible()
-      .withTimeout(15 * 1000)
-    await element(by.id('DismissBottomSheet')).tap()
-  } catch {}
-}
-
 export async function waitForElementByText(text, timeout = 30_000, index = 0) {
   try {
     index === 0

src/app/reducers.ts

@@ -31,7 +31,6 @@ interface State {
   googleMobileServicesAvailable?: boolean
   huaweiMobileServicesAvailable?: boolean
   pincodeUseExpandedBlocklist: boolean
-  rampCashInButtonExpEnabled: boolean
   sentryTracesSampleRate: number
   sentryNetworkErrors: string[]
   supportedBiometryType: BIOMETRY_TYPE | null
@@ -81,7 +80,6 @@ const initialState = {
   googleMobileServicesAvailable: undefined,
   huaweiMobileServicesAvailable: undefined,
   pincodeUseExpandedBlocklist: REMOTE_CONFIG_VALUES_DEFAULTS.pincodeUseExpandedBlocklist,
-  rampCashInButtonExpEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.rampCashInButtonExpEnabled,
   sentryTracesSampleRate: REMOTE_CONFIG_VALUES_DEFAULTS.sentryTracesSampleRate,
   sentryNetworkErrors: REMOTE_CONFIG_VALUES_DEFAULTS.sentryNetworkErrors.split(','),
   supportedBiometryType: null,
@@ -204,7 +202,6 @@ export const appReducer = (
         superchargeTokenConfigByToken: action.configValues.superchargeTokenConfigByToken,
         logPhoneNumberTypeEnabled: action.configValues.logPhoneNumberTypeEnabled,
         pincodeUseExpandedBlocklist: action.configValues.pincodeUseExpandedBlocklist,
-        rampCashInButtonExpEnabled: action.configValues.rampCashInButtonExpEnabled,
         sentryTracesSampleRate: action.configValues.sentryTracesSampleRate,
         sentryNetworkErrors: action.configValues.sentryNetworkErrors,
         skipVerification: action.configValues.skipVerification,

src/app/saga.ts

@@ -224,7 +224,6 @@ export interface RemoteConfigValues {
   superchargeApy: number
   superchargeTokenConfigByToken: SuperchargeTokenConfigByToken
   pincodeUseExpandedBlocklist: boolean
-  rampCashInButtonExpEnabled: boolean
   allowOtaTranslations: boolean
   sentryTracesSampleRate: number
   sentryNetworkErrors: string[]

src/firebase/firebase.ts

@@ -323,7 +323,6 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
       ? JSON.parse(superchargeConfigByTokenString)
       : {},
     pincodeUseExpandedBlocklist: flags.pincodeUseExpandedBlocklist.asBoolean(),
-    rampCashInButtonExpEnabled: flags.rampCashInButtonExpEnabled.asBoolean(),
     logPhoneNumberTypeEnabled: flags.logPhoneNumberTypeEnabled.asBoolean(),
     allowOtaTranslations: flags.allowOtaTranslations.asBoolean(),
     sentryTracesSampleRate: flags.sentryTracesSampleRate.asNumber(),

src/firebase/remoteConfigValuesDefaults.e2e.ts

@@ -28,7 +28,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   superchargecREALMin: 50,
   superchargecREALMax: 6000,
   pincodeUseExpandedBlocklist: true,
-  rampCashInButtonExpEnabled: false,
   logPhoneNumberTypeEnabled: false,
   allowOtaTranslations: false,
   sentryTracesSampleRate: 0.2,

src/firebase/remoteConfigValuesDefaults.ts

@@ -30,7 +30,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   superchargecREALMin: 50,
   superchargecREALMax: 6000,
   pincodeUseExpandedBlocklist: false,
-  rampCashInButtonExpEnabled: false,
   logPhoneNumberTypeEnabled: false,
   allowOtaTranslations: false,
   sentryTracesSampleRate: DEFAULT_SENTRY_TRACES_SAMPLE_RATE,