Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): remove cash in bottom sheet #5071

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Confirmed with product that this is no longer required.

Test plan

Unit tests, CI

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (9d9293c) to head (f688a83).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5071      +/-   ##
==========================================
- Coverage   85.56%   85.52%   -0.05%     
==========================================
  Files         723      722       -1     
  Lines       29489    29392      -97     
  Branches     5099     5074      -25     
==========================================
- Hits        25232    25137      -95     
+ Misses       4023     4020       -3     
- Partials      234      235       +1     
Files Coverage Δ
src/app/reducers.ts 22.82% <ø> (ø)
src/app/saga.ts 73.16% <ø> (ø)
src/firebase/firebase.ts 38.49% <ø> (ø)
src/firebase/remoteConfigValuesDefaults.ts 100.00% <ø> (ø)
src/home/WalletHome.tsx 99.06% <100.00%> (+1.33%) ⬆️
src/redux/migrations.ts 97.29% <100.00%> (+<0.01%) ⬆️
src/redux/store.ts 78.68% <ø> (ø)
test/schemas.ts 89.88% <100.00%> (+0.03%) ⬆️
test/values.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9293c...f688a83. Read the comment docs.

Copy link
Collaborator

@MuckT MuckT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cashInBottomSheetEnabled should also be removed from src/statsig/constants.ts, but otherwise LGTM.

@satish-ravi
Copy link
Contributor Author

I think cashInBottomSheetEnabled should also be removed from src/statsig/constants.ts, but otherwise LGTM.

I left it as is as it was one of the experiment params, we can clean it up when we remove the experiment.

@satish-ravi satish-ravi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 61de081 Mar 12, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/clean-bottom-sheet branch March 12, 2024 18:57
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description

Confirmed with product that this is no longer required.

### Test plan

Unit tests, CI

### Related issues

- Part of ACT-1105

### Backwards compatibility

Yes

### Network scalability

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants