Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): run assets tests against tab navigator #5115

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

Update assets test to run against the tab navigator. Retains a subset of tests on the drawer for any regression while we are in process of rolling this out.

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (52b1bbb) to head (92e8562).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5115   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files         724      724           
  Lines       29641    29640    -1     
  Branches     5121     5121           
=======================================
  Hits        25350    25350           
+ Misses       4056     4055    -1     
  Partials      235      235           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05faa1...92e8562. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 08b5527 Mar 18, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/act-1113-assets branch March 18, 2024 20:39
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description

Update assets test to run against the tab navigator. Retains a subset of
tests on the drawer for any regression while we are in process of
rolling this out.

### Test plan

CI

### Related issues

- Part of ACT-1113

### Backwards compatibility

Yes

### Network scalability

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants