Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change product name for sign in prompt #5144

Merged
merged 4 commits into from
Mar 25, 2024
Merged

chore: change product name for sign in prompt #5144

merged 4 commits into from
Mar 25, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Mar 22, 2024

Description

Changes the Product Name to Valora.

Test plan

  • Tested locally on iOS
iOS Before iOS After

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (98637c3) to head (c843a51).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5144   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files         730      730           
  Lines       29862    29862           
  Branches     5156     5156           
=======================================
+ Hits        25592    25593    +1     
+ Misses       4035     4034    -1     
  Partials      235      235           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98637c3...c843a51. Read the comment docs.

@MuckT
Copy link
Collaborator Author

MuckT commented Mar 22, 2024

@jeanregisser do you know if changes to all these files are needed? I changed the product name as shown in openid/AppAuth-iOS#343 (comment) and rebuilt which resulted in quite a few name changes.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MuckT MuckT marked this pull request as ready for review March 25, 2024 16:01
@MuckT MuckT added this pull request to the merge queue Mar 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2024
@MuckT MuckT added this pull request to the merge queue Mar 25, 2024
@MuckT MuckT removed this pull request from the merge queue due to a manual request Mar 25, 2024
Copy link

emerge-tools bot commented Mar 25, 2024

1 build increased size

Name Version Download Change Install Change Approval
⚠️ Celo (test)
org.celo.mobile.test
1.81.0 (146) 26.6 MB ⬆️ 2.4 MB (9.81%) 63.1 MB ⬆️ 2.7 MB (4.45%) N/A

Celo (test) 1.81.0 (146)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.7 MB (4.45%)
Total download size change: ⬆️ 2.4 MB (9.81%)

Largest size changes

Item Install Size Change
🗑 celo ⬇️ -15.5 MB
📝 valora ⬆️ 1.6 MB
📝 Lottie ⬆️ 782.7 kB
📝 Code Signature ⬆️ 662.6 kB
📝 Strings.CFStrings ⬆️ 650.6 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@MuckT MuckT enabled auto-merge March 25, 2024 17:58
@MuckT MuckT added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 3338ec9 Mar 25, 2024
16 checks passed
@MuckT MuckT deleted the tomm/act-873 branch March 25, 2024 18:41
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description

Changes the Product Name to Valora.

### Test plan

- Tested locally on iOS

| iOS Before | iOS After | 
| ---- | ---- |
|
![](https://github.com/valora-inc/wallet/assets/26950305/45478929-c91c-4317-a126-bc225c5165d8)
|
![](https://github.com/valora-inc/wallet/assets/26950305/02640837-094f-40b6-a1f8-c6027fc81c01)
|

### Related issues

- Fixes ACT-873

### Backwards compatibility

Yes

### Network scalability

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants