-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change product name for sign in prompt #5144
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5144 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 730 730
Lines 29862 29862
Branches 5156 5156
=======================================
+ Hits 25592 25593 +1
+ Misses 4035 4034 -1
Partials 235 235 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@jeanregisser do you know if changes to all these files are needed? I changed the product name as shown in openid/AppAuth-iOS#343 (comment) and rebuilt which resulted in quite a few name changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
1 build increased size
Celo (test) 1.81.0 (146)
|
Item | Install Size Change |
---|---|
🗑 celo | ⬇️ -15.5 MB |
📝 valora | ⬆️ 1.6 MB |
📝 Lottie | ⬆️ 782.7 kB |
📝 Code Signature | ⬆️ 662.6 kB |
📝 Strings.CFStrings | ⬆️ 650.6 kB |
🛸 Powered by Emerge Tools
### Description Changes the Product Name to Valora. ### Test plan - Tested locally on iOS | iOS Before | iOS After | | ---- | ---- | | ![](https://github.com/valora-inc/wallet/assets/26950305/45478929-c91c-4317-a126-bc225c5165d8) | ![](https://github.com/valora-inc/wallet/assets/26950305/02640837-094f-40b6-a1f8-c6027fc81c01) | ### Related issues - Fixes ACT-873 ### Backwards compatibility Yes ### Network scalability N/A
Description
Changes the Product Name to Valora.
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A