-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASWebAuthenticationSession and SFAuthenticationSession use the target name instead of bundle display name #343
Comments
I always thought it was the app name, but now that you raise this I've never directly confirmed that, nor do I know how to change it. Hopefully someone here knows the answer! So to be clear, it's not using the name that shows under your app's icon on the homescreen? |
@WilliamDenniss no it does not, it uses either target name or project name, I am not sure which one it is using. As you can see target name is Hugin, but the display name is |
I also tested on my side and confirm this is the target name that is used (not the project name). It appears to be a bug from Apple's |
It is really annoying, luckily our team has their own identity server and our stake holders are okay with using the identity server without sso. So I created a gist and by passing the alertview for now. https://gist.github.com/ugenlik/2a543f351e9b9425800b48266760dc85 |
Glad you resolved it for your case @ugenlik. I would expect the standard workaround for this to be renaming the target to the desired name. |
Closing this as there's not much we can do on the AppAuth side, and we have a known workaround, but feel free to continue commenting for how you all workaround this, and if any changes to the OS behavior are observed! |
Struggling with the same problem, I found that what is set in |
Describe the bug
When using
OIDAuthState.authState(byPresenting: request, presenting: viewController)
there is an alertview for devices greater than iOS 11 for single-sign on. Which is obvious.But the problem is alertview uses
scheme
name of the app notDisplay Name
from the Info.plist or bundle identifier name from bundle.Which makes it very confusing for the user, because name of my App is
GO
, but the project scheme/workspace name isHUGIN
and user sees following when try to login:
User doesn't know what HUGIN is , so it is incredibly confusing for everybody.
They need to see either one of this values:
Is there a way to pass the Display Name to system so OS doesnt use the
scheme
name ???To Reproduce
Steps to reproduce the behavior , just use
OIDAuthState.authState(byPresenting
in iOS 11 or iOS 12The text was updated successfully, but these errors were encountered: