chore(jumpstart): support for reclaim from retired jumpstart contracts #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build had no size change
Celo (test) 1.81.0 (146)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5200 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 744 744
Lines 30345 30348 +3
Branches 5238 5238
=======================================
+ Hits 26030 26033 +3
Misses 4076 4076
Partials 239 239
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Apr 2, 2024
| const jumpstartAddresses = [ | ||
| jumpstartConfig?.contractAddress, | ||
| ...(jumpstartConfig?.retiredContractAddresses ?? []), | ||
| ].filter((address): address is string => !!address) |
There was a problem hiding this comment.
nit: we have a helper for this.
Suggested change
| ].filter((address): address is string => !!address) | |
| ].filter(isPresent) |
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
valora-inc#5200) ### Description This PR adds a `retiredContractAddresses` to the jumpstart dynamic config. If we need to change the contract for whatever reason, we should still allow users to reclaim their funds that were sent to previous versions of the contract. The only place we need to do this is in the transaction classification stage - we should mark transactions to _any_ jumpstart contract appropriately, from there the jumpstart transaction details screen will allow reclaim from that contract directly. Of course this logic relies on the abi of the jumpstart contracts staying the same, since a single abi is baked into the app. ### Test plan Unit tests ### Related issues n/a ### Backwards compatibility Y ### Network scalability Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
retiredContractAddressesto the jumpstart dynamic config.If we need to change the contract for whatever reason, we should still allow users to reclaim their funds that were sent to previous versions of the contract. The only place we need to do this is in the transaction classification stage - we should mark transactions to any jumpstart contract appropriately, from there the jumpstart transaction details screen will allow reclaim from that contract directly.
Of course this logic relies on the abi of the jumpstart contracts staying the same, since a single abi is baked into the app.
Test plan
Unit tests
Related issues
n/a
Backwards compatibility
Y
Network scalability
Y