chore(points): Use activityId and pointsAmount throughout #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 86.08% 86.08% -0.01%
==========================================
Files 747 747
Lines 30671 30675 +4
Branches 5313 5314 +1
==========================================
+ Hits 26403 26406 +3
- Misses 4036 4037 +1
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kathaypacific
approved these changes
Apr 16, 2024
src/points/ActivityCard.tsx
Outdated
| @@ -11,26 +11,26 @@ import ValoraAnalytics from 'src/analytics/ValoraAnalytics' | |||
| import { PointsEvents } from 'src/analytics/Events' | |||
|
|
|||
| interface Props { | |||
| activity: PointsActivity | |||
| activityId: PointsActivity | |||
| points: number | |||
There was a problem hiding this comment.
should this also be pointsAmount?
bakoushin
reviewed
Apr 16, 2024
kathaypacific
approved these changes
Apr 18, 2024
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…#5255) ### Description Updates the points implementation + redux to use `activityId` and `pointsAmount` everywhere, as discussed in Slack. ### Test plan Manual/unit tested. ### Related issues Part of [ACT-1032](https://linear.app/valora/issue/RET-1032/[wallet-fake-backend]-points-activity-history). ### Backwards compatibility Yes. ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the points implementation + redux to use
activityIdandpointsAmounteverywhere, as discussed in Slack.Test plan
Manual/unit tested.
Related issues
Part of ACT-1032.
Backwards compatibility
Yes.
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: