-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(points): Use activityId and pointsAmount throughout #5255
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 86.08% 86.08% -0.01%
==========================================
Files 747 747
Lines 30671 30675 +4
Branches 5313 5314 +1
==========================================
+ Hits 26403 26406 +3
- Misses 4036 4037 +1
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅🏼🚀
src/points/ActivityCard.tsx
Outdated
@@ -11,26 +11,26 @@ import ValoraAnalytics from 'src/analytics/ValoraAnalytics' | |||
import { PointsEvents } from 'src/analytics/Events' | |||
|
|||
interface Props { | |||
activity: PointsActivity | |||
activityId: PointsActivity | |||
points: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this also be pointsAmount
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, good call!
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
…#5255) ### Description Updates the points implementation + redux to use `activityId` and `pointsAmount` everywhere, as discussed in Slack. ### Test plan Manual/unit tested. ### Related issues Part of [ACT-1032](https://linear.app/valora/issue/RET-1032/[wallet-fake-backend]-points-activity-history). ### Backwards compatibility Yes. ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Description
Updates the points implementation + redux to use
activityId
andpointsAmount
everywhere, as discussed in Slack.Test plan
Manual/unit tested.
Related issues
Part of ACT-1032.
Backwards compatibility
Yes.
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: