revert(iOS): revert unnecessary privacy manifest (#5266) #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e07c16b.
kathaypacific
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5296 +/- ##
==========================================
- Coverage 86.01% 86.01% -0.01%
==========================================
Files 746 746
Lines 30520 30520
Branches 5291 5291
==========================================
- Hits 26252 26251 -1
- Misses 4036 4037 +1
Partials 232 232 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…alora-inc#5296) ### Description This reverts commit e07c16b. I misunderstood the Apple documentation - we cannot declare the privacy manifest on behalf of third-party SDK's (the privacy manifest needs to be at the same "level" as the usage). ### Test plan n/a ### Related issues - Related to RET-1058 ### Backwards compatibility Y ### Network scalability Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit e07c16b. I misunderstood the Apple documentation - we cannot declare the privacy manifest on behalf of third-party SDK's (the privacy manifest needs to be at the same "level" as the usage).
Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
Y